Removing the object_wrap.h

4 views
Skip to first unread message

Marco Rogers

unread,
Jan 13, 2012, 7:40:29 PM1/13/12
to libx...@googlegroups.com
Roman:

I noticed that you removed the custom ref management function I had in there and replaced start using the standard node ObjectWrap. Sorry I didn't notice this before. I spent a lot of time getting that right in order to prevent memory leaks. I'll have to refresh myself on why I had to make my own object wrap. If we don't need it great. But I remember it being pretty necessary. Can you say why you felt it was safe to remove?

:Marco

--
Marco Rogers
marco....@gmail.com | https://twitter.com/polotek

Life is ten percent what happens to you and ninety percent how you respond to it.
- Lou Holtz

Roman Shtylman

unread,
Jan 13, 2012, 8:26:10 PM1/13/12
to libx...@googlegroups.com
After looking at it for a bit, I felt that using the builtin ObjectWrap would be acceptable and cut down on the amount of code. Using the builtin object wrap also means that we benefit from any bug fixes or improvements made there versus rolling our own version of basically the same thing.

I moved some of the logic into static methods for each of the types of objects needing creation.
Reply all
Reply to author
Forward
0 new messages