googletest last fix

[Ulf Lorenz]

Hi,

just to attack the next issue: googletest was making problems,
because when it is found, a relative path is set for GTEST_DIR, but if
it is automatically downloaded, an _absolute_ path was set. Attached is
a simple fix that essentially replaces the absolute path by a relative
one.


Ulf

[Juan Jose Garcia-Ripoll]

I am afraid the patch does not work for me. It took me some time to realise the kind of problems you are experiencing arise from the fact that you build lib tensor from inside the libtensor directory, while I always build from some other directory, because I make many different builds. Indeed all the software I design normally is prepared to be configured and built from some other directory.

My feeling is that both paths should be absolute, not relative. The fact that "configure" makes ac_confdir relative is a bit unfortunate. Wouldn't there be another way to fix this?

Juanjo

--
Instituto de Física Fundamental, CSIC
c/ Serrano, 113b, Madrid 28006 (Spain) 
http://juanjose.garciaripoll.googlepages.com

[Ulf Lorenz]

On Mon, 25 Nov 2013 10:22:07 +0100
Juan Jose Garcia-Ripoll <juanjose.g...@gmail.com> wrote:

> My feeling is that both paths should be absolute, not relative. The
> fact that "configure" makes ac_confdir relative is a bit unfortunate.
> Wouldn't there be another way to fix this?

There might be a way to get the absolute top level dir or so somewhere.
The patch was what I could produce after a bit of perusal of the
autotools documentation, which was rather silent on, e.g., ac_confdir.

I would have a deeper look into autotools, there is probably a fix
hidden somewhere .


Ulf

[Ulf Lorenz]

On Mon, 25 Nov 2013 10:22:07 +0100
Juan Jose Garcia-Ripoll <juanjose.g...@gmail.com> wrote:

> My feeling is that both paths should be absolute, not relative. The
> fact that "configure" makes ac_confdir relative is a bit unfortunate.
> Wouldn't there be another way to fix this?

Looking into the autoconf files suggested that there is a corresponding
absolute path as well. Patch attached.


Ulf

[Juan Jose Garcia-Ripoll]

It's now in.