[seccomp/libseccomp] 5731b3: tests: fix 54-live-binary_tree to use binary tree

Skip to first unread message

Kir Kolyshkin

Mar 15, 2022, 10:38:58 PM3/15/22
to libse...@googlegroups.com
Branch: refs/heads/main
Home: https://github.com/seccomp/libseccomp
Commit: 5731b3c338f8f18b1d2b3aa300bbcb97af0fb34c
Author: Kir Kolyshkin <koly...@gmail.com>
Date: 2022-03-15 (Tue, 15 Mar 2022)

Changed paths:
M tests/54-live-binary_tree.c
M tests/54-live-binary_tree.py

Log Message:
tests: fix 54-live-binary_tree to use binary tree

Apparently, an early implementation of the binary tree optimization
used to enable the feature when the number of rules added was > 16.

The code was later changed to add and use SCMP_FLTATR_CTL_OPTIMIZE,
but the 54-live-binary_tree test case was left as is. So, despite
its name, it is not testing the binary tree.

Fix this, and remove the comment that referred to the old

Fixes: 38f04da84748 ("tests: add tests for the binary tree")
Reviewed-by: Tom Hromatka <tom.hr...@oracle.com>
Signed-off-by: Kir Kolyshkin <koly...@gmail.com>
[PM: restyled the "Fixes" tag]
Signed-off-by: Paul Moore <pa...@paul-moore.com>

Reply all
Reply to author
0 new messages