Issue 281 in libnfc: cmake soversion doesn't match autotools

3 views
Skip to first unread message

lib...@googlecode.com

unread,
Jul 2, 2014, 2:58:38 AM7/2/14
to libnfc...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 281 by julien.s...@gmail.com: cmake soversion doesn't match
autotools
http://code.google.com/p/libnfc/issues/detail?id=281

Hi,

nfc soversion is 5:1:0

hence in cmake stuff we should do:
SET_TARGET_PROPERTIES(nfc PROPERTIES SOVERSION 5 VERSION 5.0.1)

I guess maintaining these two both Makefile.am and CMakeLists.txt is
tedious,
but autotools support is supposed to be dropped one day right ?

diff --git a/libnfc/CMakeLists.txt b/libnfc/CMakeLists.txt
index 66d2124..7a51bb0 100644
--- a/libnfc/CMakeLists.txt
+++ b/libnfc/CMakeLists.txt
@@ -89,7 +89,7 @@ IF(LIBUSB_FOUND)
TARGET_LINK_LIBRARIES(nfc ${LIBUSB_LIBRARIES})
ENDIF(LIBUSB_FOUND)

-SET_TARGET_PROPERTIES(nfc PROPERTIES SOVERSION 0)
+SET_TARGET_PROPERTIES(nfc PROPERTIES SOVERSION 5 VERSION 5.0.1)

IF(WIN32)
# Libraries that are windows specific


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
Reply all
Reply to author
Forward
0 new messages