libcpu uint64_t

[Brian Brooks]

Hi,

I am compiling libcpu on Ubuntu 64-bit.

Looks like there is a type mismatch for uint64_t:

typedef unsigned long long uint64_t;  (libcpu/types.h)

vs

typedef unsigned long uint64_t;    (/usr/include/stdint.h)

I tried changing the type to "unsigned long", and then hacked at the rest of the source with a huge hammer... llu -> lu , etc...

This seems hopeless and I am not sure it's a correct way to fix.  What's the appropriate way to fix?

Thanks,

Brian

[Pekka Enberg]

It's a mess. Dunno who came up with the typedefs but we absolutely can't
use 'uint64_t' for something we define ourselves. I'm guessing the simplest
thing to do here is to rip out all the unsigned typedefs in favor of <stdint.h>
and convert the code to use 'intXX_t' instead of 'sintXX_t' for signed types.

Pekka

[Pekka Enberg]

I did the following simple fix for the issue:

https://github.com/libcpu/libcpu/commit/793f2cde235cce1fd5d43e93e61a4c05faece0c0

[Gianluca Guida]

The problem is that [u]int64_t is not required by POSIX to be defined in non-64 bit architectures.
So the proper solution is to get a way (there should be a pretty much standard one) to define it when undefined and leave the stdint.h one when the C library provides us with this type.

What you did in your patch (next email) goes into that direction, I would also substitute all the printf's that eventually use "llu" with PRI?64 from inttypes.h as well.

Gianluca