final test before 1.0

[Joshua Marinacci]

Hi guys. I think we are about ready for the final 1.0 release of Leonardo Sketch.  Could you please test the latest build here, in particular check for gaps in the translation file.  We are almost there. Thanks everyone!

http://projects.joshy.org/Leonardo/daily/

- Josh

[Davor Hrg]

Hi,

1. color dialog does not correct it's position when shown (can go outside window)

     object properties dialog fixes it's position.

2. there is no undo for changes in style
  - add circle

 - move circle

 - change color

 - change stroke

 - undo 

 - ERR: circle moves back, with latest change in style

3. opacity is not applied to background when gradient

 - fix proposal: update all colors from gradient to include the apropriate alpha

4. convert to path does not work for rounded rect

 - draw rect

 - round corners

 - convert to path

 - path is rect without rounded corners

suggestions:
1. : opacity should affect both bg and line

 - either both use same opacity

 - or there is separate opacity for line (maybe by including opacity for color picker)

2. add ok/cancel to object properties

 - preview is great and should stay

adding ok/cancel can make playing with style easier (less stress)

and also less steps for undo, as undo can be recorded after ok is clicked

[Joshua Marinacci]

On Oct 14, 2011, at 12:51 AM, Davor Hrg wrote:

Hi,

1. color dialog does not correct it's position when shown (can go outside window)

     object properties dialog fixes it's position.

Can you describe when this happens? The color dialog should branch off of the object properties pallet which will now always be drawn on screen (at least as much as possible) by moving to a better position.

2. there is no undo for changes in style
  - add circle

 - move circle

 - change color

 - change stroke

 - undo 

 - ERR: circle moves back, with latest change in style

you are right. I'll fix it.

3. opacity is not applied to background when gradient

 - fix proposal: update all colors from gradient to include the appropriate alpha

so if you choose a gradient the overall alpha slider should affect it, right? probably the same with the texture as well.

4. convert to path does not work for rounded rect

 - draw rect

 - round corners

 - convert to path

 - path is rect without rounded corners

hmm. i thought it did. i'll fix it.

suggestions:

1. : opacity should affect both bg and line

 - either both use same opacity

 - or there is separate opacity for line (maybe by including opacity for color picker)

agreed.

2. add ok/cancel to object properties

 - preview is great and should stay

adding ok/cancel can make playing with style easier (less stress)

and also less steps for undo, as undo can be recorded after ok is clicked

Are you saying that the object properties pallet should have an okay /cancel button as the only way to make the changes permanent? what happens when you make a change then select a different object? should the changes be permanent?  what about just a cancel button, or maybe revert / undo.

thanks for the feedback.  what features do you think are still missing for the app to be useful to you?

- Josh

[Davor Hrg]

err: 1. color dialog does not correct it's position when shown (can go outside window)

     object properties dialog fixes it's position.

 - draw circle near bottom of screen

 - click circle so object properties box as close to bottom(of window) as possible

 - click color chooser for border, or backgroud

 - ERR both are cropped at bottom as are out of window boundaries

suggestion: 2. add ok/cancel to object properties

it is more important to have undo for style changes,

the ok/cancel button is just an vague idea...

make undo work for style changes and all is fine ...

as for features I am missing...

I have a technical approach to vector graphics and usually do it

based on simpler geometry or mimicing someone elses style.

#1 a way to scale shape with thick lines without ruining it

I use openoffice draw (as strange as it may sound) because I

got used to it's nice features when grouping objects.

When creating a more complex graphic, it becomes very importanat

for me to group and duplicate stuff and scale the groups.

Also when I want to keep the proportions right I convert a shape to

cuntour. This enables me to create a shape with thick lines and

then when converted to countour, lines become shapes themself.

This is important because after that I can resize the shape and make it much smaller

if needed without ruining it.

I line stays line, making a shape much smaller leaves line thickness as is and

the smaller version looks nothing like the bigger one.

(attached image)

 - 1 original shape

 - 2 scaled with line thickness ruining it

 - converted to contour, then scaled 

#2 editing groups without ungrouping

[Davor Hrg]

I sent the mail too soon

so ... to continue:

#2 editing groups without ungrouping

when editing in openoffice I can group stuff multiple times as in leonardo

but in leo I need to ungoup to access the elements inside.

This is not a good option with complex shapes.

In openoffice I can select a group and F3 to edit it, and if inside it are

more groups I can F3 to edit them ... nad so on (CTRL+F3 goes back a level)

This relly makes complex shapes manageable.

#3 group scaling

 - 

I can't say anyone else needs these features, ... it's just how I do it.

Davor Hrg

[Davor Hrg]

found one more bug,

 - add circle 1

 - add circle 2 with overlap

 - select both

 - menu -> path ->add

 - menu -> path -> convert shape to path

 - ERR app blocks, must kill editing window

 

I ran it from console and then got:

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException

        at org.joshy.sketch.canvas.SketchCanvas.recalcMaxExtent(SketchCanvas.java:327)

        at org.joshy.sketch.canvas.SketchCanvas.draw(SketchCanvas.java:139)

        at org.joshy.gfx.node.control.ScrollPane$1.draw(ScrollPane.java:71)

        at org.joshy.gfx.node.control.ScrollPane.draw(ScrollPane.java:297)

        at org.joshy.gfx.node.layout.Panel.draw(Panel.java:80)

        at org.joshy.gfx.node.layout.Panel.draw(Panel.java:80)

        at org.joshy.gfx.node.layout.Panel.draw(Panel.java:80)

        at org.joshy.gfx.stage.swing.SwingStage$2.draw(SwingStage.java:260)

        at org.joshy.gfx.stage.swing.SwingStage$1.draw(SwingStage.java:217)

        at org.joshy.gfx.stage.swing.SwingStage$SceneComponent.doGFXDrawing(SwingStage.java:515)

        at org.joshy.gfx.stage.swing.SwingStage$SceneComponent.paintComponent(SwingStage.java:487)

        at javax.swing.JComponent.paint(Unknown Source)

        at javax.swing.JComponent.paintChildren(Unknown Source)

        at javax.swing.JComponent.paint(Unknown Source)

        at javax.swing.JComponent.paintToOffscreen(Unknown Source)

        at javax.swing.RepaintManager$PaintManager.paintDoubleBuffered(Unknown Source)

        at javax.swing.RepaintManager$PaintManager.paint(Unknown Source)

        at javax.swing.RepaintManager.paint(Unknown Source)

        at javax.swing.JComponent._paintImmediately(Unknown Source)

        at javax.swing.JComponent.paintImmediately(Unknown Source)

        at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)

        at javax.swing.RepaintManager.paintDirtyRegions(Unknown Source)

        at javax.swing.RepaintManager.seqPaintDirtyRegions(Unknown Source)

        at javax.swing.SystemEventQueueUtilities$ComponentWorkRequest.run(Unknown Source)

        at java.awt.event.InvocationEvent.dispatch(Unknown Source)

        at java.awt.EventQueue.dispatchEvent(Unknown Source)

        at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)

        at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)

        at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)

        at java.awt.EventDispatchThread.pumpEvents(Unknown Source)

        at java.awt.EventDispatchThread.pumpEvents(Unknown Source)

On Fri, Oct 14, 2011 at 5:29 AM, Joshua Marinacci <jos...@marinacci.org> wrote:

[Joshua Marinacci]

On Oct 15, 2011, at 4:21 AM, Davor Hrg wrote:

err: 1. color dialog does not correct it's position when shown (can go outside window)

     object properties dialog fixes it's position.

 - draw circle near bottom of screen

 - click circle so object properties box as close to bottom(of window) as possible

 - click color chooser for border, or backgroud

 - ERR both are cropped at bottom as are out of window boundaries

I've addressed this by making the object properties dialog leave more space for the color picker.

suggestion: 2. add ok/cancel to object properties

it is more important to have undo for style changes,

the ok/cancel button is just an vague idea...

make undo work for style changes and all is fine ...

as for features I am missing...

I have a technical approach to vector graphics and usually do it

based on simpler geometry or mimicing someone elses style.

Okay. I'll start with the undo for style changes and we'll think about more advanced checkpointing / reverting for the next version.

#1 a way to scale shape with thick lines without ruining it

I use openoffice draw (as strange as it may sound) because I

got used to it's nice features when grouping objects.

When creating a more complex graphic, it becomes very importanat

for me to group and duplicate stuff and scale the groups.

Also when I want to keep the proportions right I convert a shape to

cuntour. This enables me to create a shape with thick lines and

then when converted to countour, lines become shapes themself.

This is important because after that I can resize the shape and make it much smaller

if needed without ruining it.

I line stays line, making a shape much smaller leaves line thickness as is and

the smaller version looks nothing like the bigger one.

(attached image)

 - 1 original shape

 - 2 scaled with line thickness ruining it

 - converted to contour, then scaled 

Okay, I understand now. When you scale a shape sometimes you want to scale the whole thing, strokes and all, and sometimes you want to just scale up the geometry.  How about a second transform tool that looks just like the first but it transforms geometry instead of the entire shape? Transform is command/control-T  how about shift-command-T for the other one?

#2 editing groups without ungrouping

I agree. I'm afraid it requires some serious changes under the hood, however, so it will have to wait for the next version.

- J

<Clipboard01.jpg>

[Joshua Marinacci]

On Oct 14, 2011, at 12:51 AM, Davor Hrg wrote:

Hi,

1. color dialog does not correct it's position when shown (can go outside window)

     object properties dialog fixes it's position.

fixed now

2. there is no undo for changes in style
  - add circle

 - move circle

 - change color

 - change stroke

 - undo 

 - ERR: circle moves back, with latest change in style

3. opacity is not applied to background when gradient

 - fix proposal: update all colors from gradient to include the appropriate alpha

this is fixed now in two forms.  For patterns it will respect the alpha, just as fill colors do. For gradients you can specify the alpha on each stop using a second popup right next to the color popup. Please try it out and let me know what you think.

4. convert to path does not work for rounded rect

 - draw rect

 - round corners

 - convert to path

 - path is rect without rounded corners

fixed.

suggestions:
1. : opacity should affect both bg and line

 - either both use same opacity

 - or there is separate opacity for line (maybe by including opacity for color picker)

for the stroke I think the long term solution is to put opacity into color pickers.

- Josh

[Joshua Marinacci]

I can reproduce this now. I'll fix it.

-j

[Davor Hrg]

Hi:

#1 a way to scale shape with thick lines without ruining it

Okay, I understand now. When you scale a shape sometimes you want to scale the whole thing, strokes and all, and sometimes you want to just scale up the geometry.  How about a second transform tool that looks just like the first but it transforms geometry instead of the entire shape? Transform is command/control-T  how about shift-command-T for the other one?

Yes, of course. It is important to have this option, and how it is implemented is not.

I would also expect for when group scaling is implemented that the default will be

 scaling both lines and geometry.

[Davor Hrg]

Hi,

another Undo issue:

Align actions not in undo

 - draw circle 1

 - draw circle 2 above and to the right

 - select both

 - align to left
 - undo

- ERR: movement is not undoed

Aslo a small align issue:

Presing align multiple times does not stop moving

 - draw 2 circles of different sizes

 - select both

 - align left (looks ok)

 - click align left multiple times 

 - ERR - circles keep moving  

similar thing happen for other alignments

A bigger align issue: 

poly and multi-sided shape do not align even closely

 - draw poly or multi-sided shape

 - draw circle

 - select both

 - use any align

 - ERR - align not as expected in many combinations

Likely miscalculation for bounds

Davor

On Fri, Oct 14, 2011 at 5:29 AM, Joshua Marinacci <jos...@marinacci.org> wrote: