Leo 6.7.4 will be delayed for at least a week.

[Edward K. Ream]

Félix has discovered a serious undo bug that has been around for years. That's good because it means my recent work is not the culprit :-)

His fix creates a way of undoing/redoing arbitrary changes to trees.

Félix has also convinced me that commands like refresh-from-disk should be undoable. These commands will use his new undo/redo scheme. 

Summary

Félix will soon create a new issue that describes a significant bug and its fix. The fix will show how to undo changes throughout a tree.

Commands such as refresh-from-disk will soon be undoable.

These changes will be part of Leo 6.7.4.

Edward

[Félix]

The issue was created right after we spoke: https://github.com/leo-editor/leo-editor/issues/3446 

But it's not about undo/redo: It's about paste-as-clone, which is bugged. (the inner clones of subtrees are not clones after pasting - as opposed to paste-as-template which seems to work fine)

the undo/redo of "arbitrary treeChanges" is another thing, which I'll implement right after this issue is solved.

Félix

[Edward K. Ream]

On Thursday, July 20, 2023 at 6:45:17 PM UTC-5 Félix wrote:

The issue was created right after we spoke: https://github.com/leo-editor/leo-editor/issues/3446 

I've just created PR #3449. At present the PR contains only a failing unit test, modeled exactly on the outline shown in #3446.

As you can see from "Test Output" details, paste-retaining-clones handles gnxs properly but messes up v.parents. I think this is good news, but we'll see.

More tomorrow.

Edward

[Edward K. Ream]

On Thursday, July 20, 2023 at 9:22:25 PM UTC-5 Edward K. Ream wrote:

I've just created PR #3449. At present the PR contains only a failing unit test, modeled exactly on the outline shown in #3446.

The PR is ready for review. See the first comment of the PR for full details. I created a strong new unit test.

The only change to Leo's code was a one-line fix for a significant blunder. It's hard to know how much damage that blunder could have caused!

Please test the ekr-3446-paste-as-clone and report any problems:

git fetch

git checkout ekr-3446-paste-as-clone

Edward