PR #2694 simplifies and renames g.TypedDict to g.SettingsDict

25 views
Skip to first unread message

Edward K. Ream

unread,
Jun 26, 2022, 7:07:45 AM6/26/22
to leo-editor
PR #2694 improves a class that has bothered me for a decade or more. The new code has been merged into devel and felix-server4.

The SettingsDict class is now a subclass of dict, which simplifies the code. The new class contains just a few utilities related to settings dicts, so the new name is more appropriate.

The old class clumsily provided type checking. The new class leaves type checking to mypy.

The new code will ripple into LeoJS, but imo the work will be worthwhile.

I have taken care to make no substantial functional changes to the SettingsDict class. Please report any problems immediately. We aren't going back to the old way.

Edward

Félix

unread,
Jun 26, 2022, 9:07:05 PM6/26/22
to leo-editor
Thanks! 

i'll convert those changes to leojs for sure.

I've been pretty silent and unproductive in the last 2-3 days as i got covid! i'm ok now and will be working on this soon. 

(thanks for those 4 vaccines shots i had received, this whole thing was just 3 days of muscle ache and feeling weak and sleepy: Not even cough or sneezed once.)

Félix

Edward K. Ream

unread,
Jun 27, 2022, 7:39:35 AM6/27/22
to leo-editor
On Sunday, June 26, 2022 at 8:07:05 PM UTC-5 Félix wrote:

I've been pretty silent and unproductive in the last 2-3 days as i got covid! i'm ok now and will be working on this soon. 

(thanks for those 4 vaccines shots i had received, this whole thing was just 3 days of muscle ache and feeling weak and sleepy: Not even cough or sneezed once.)

Whew! I'm glad you are recovering! Several friends have gotten covid in Madison, and the medflight helicopters are constantly taking people to nearby hospitals. Those that think that normal life can resume are fooling themselves.

Edward
Reply all
Reply to author
Forward
0 new messages