how to stop leo stealing focus when file changes outside leo

[nic cave-lynch]

Hi

Subject says it all, really. 

doing something like a `git stash` in a console window on a file that's controlled by Leo causes Leo to show the 'this has changed outside leo' dialog. That's fine, except the dialog steals focus, which is ... tedious. 

I've tried looking through the code to find where that happens, but with no success.

Any hints would be welcome.

Thanks

Nic

[Edward K. Ream]

On Wednesday, September 13, 2023 at 5:29:14 PM UTC-5 nic cave-lynch wrote:

doing something like a `git stash` in a console window on a file that's controlled by Leo causes Leo to show the 'this has changed outside leo' dialog. That's fine, except the dialog steals focus, which is ... tedious. 

I've tried looking through the code to find where that happens, but with no success.

Any hints would be welcome.

Focus issues are notoriously complicated.  I usually exit Leo whenever I am about to change branches.

Can you describe in detail what the "before" and "after" focuses are? I can then create a new Leo issue.

Edward

[nic cave-lynch]

before git stash save (or whatever), focus is in console window. After git stash save, leo takes focus with the 'something has change outside leo' dialog.

I'm happy for the dialog to appear, but I'd really rather it did not take focus away from the console window that I'm working in

[HaveF HaveF]

before git stash save (or whatever), focus is in console window. After git stash save, leo takes focus with the 'something has change outside leo' dialog.

I'm happy for the dialog to appear, but I'd really rather it did not take focus away from the console window that I'm working in

In this scenario, it sounds a bit annoying.

- Maybe an option to `refresh quiet` would be better? After all, in the context of Git, everything is already tracked.

- Or like the browser, there is a back function, it would be better to go back to the previous page/view?

 

[Edward K. Ream]

On Wednesday, September 13, 2023 at 5:29:14 PM UTC-5 nic cave-lynch wrote:

Subject says it all, really. 

I have just created #3601.

The issue just bit me as I was testing PR #3597. This was good luck. The PR defines two helper functions that should help solve the problem. Plus I know how to test any proposed fix ;-)

Edward