Head up: PR #4121 (in devel) may cause problems

[Edward K. Ream]

I encountered strange behavior after merging #4121 into devel. Leo opened with a different layout than the one my settings specified. The workaround was to execute the 'layout-quadrant' command.

Imo, the "devel" branch is unacceptable. I am working on an urgent fix, PR #4126.

I plan to complete and pull the PR later today. My apologies for this mess.

Edward

[Thomas Passin]

Please coordinate changes with me.

[Thomas Passin]

What layout is in your settings?

On Friday, October 25, 2024 at 2:59:42 PM UTC-4 Edward K. Ream wrote:

[Thomas Passin]

I just went through them all in turn and Leo started up with the right layout each time.

I tested by putting the setting node into the setting tree in my workbook.leo outline, changing the specified layout, and starting a new session of Leo that opens just the workbook.

I am aware of a problem I've had from time to time where VR (not VR3) doesn't show up.  The log pane shows the message that the VR pane has been turned on or off but VR isn't actually visible.  As you said, there's a workaround so I thought we could tackle it after getting the layout machinery into devel.

If VR doesn't show itself one might get fooled into thinking that the wrong layout had been loaded - depending on the layout, of course.

[Edward K. Ream]

On Friday, October 25, 2024 at 2:04:24 PM UTC-5 Thomas wrote:

Please coordinate changes with me.

I am going to merge this emergency PR without discussion. I'll take full responsibility for doing so.

Edward

[Thomas Passin]

I tested all the layouts in a Linux VM too and they all worked as intended.  All except the one where I had a typo.  Are you sure that didn't happen to you?  Which layout had you specified, and what did you get?

[Edward K. Ream]

On Fri, Oct 25, 2024 at 4:33 PM Thomas Passin <tbp1...@gmail.com> wrote:

I tested all the layouts in a Linux VM too and they all worked as intended.  All except the one where I had a typo.  Are you sure that didn't happen to you?  Which layout had you specified, and what did you get?

I specified the legacy layout and got the vertical thirds. It's all very strange, but it doesn't matter now.

However, it's not ok with me to use anything other than 'legacy' for the default layout. People can use myLeoSettings.leo to set their own preferred default.

Edward

[Thomas Passin]

When we were posting about what layouts to remove "legacy" came up among others.  I said I wanted to keep the ones aliased to the other names because someone might be using them.  You responded that devel was unstable anyway and removing the aliases wouldn't matter because people would get used to the changes. I was under the impression, perhaps wrongly, that you wanted to keep "quadrant" and get rid of "legacy".  I don't know who else would know what "legacy" is supposed to mean, anyway.  Here's the conversation from your post -

"On Wed, Oct 23, 2024 at 7:19 AM Thomas Passin <tbp1...@gmail.com> wrote:

* ==> What's the difference b/w 'legacy' & 'quadrant' command ?
* ==> I do not see any & would remove 'quadrant' !

There isn't a difference and "legacy" has already been removed. It is still aliased to "quadrant" for the time being in case anyone is using it by that name.  I think that Edward may want to remove "quadrant" as well but that's not decided for sure.

Thomas, imo there is no reason to retain confusing command names. There is no downside to doing so. The names are recent, people have no right to expect stability just yet, and changing them does not constitute a breaking change to Leo."

[Edward K. Ream]

On Fri, Oct 25, 2024 at 5:11 PM Thomas Passin <tbp1...@gmail.com> wrote:

> When we were posting about what layouts to remove "legacy" came up among others.  I said I wanted to keep the ones aliased to the other names because someone might be using them.  You responded that devel was unstable anyway and removing the aliases wouldn't matter because people would get used to the changes. 

Still true.

> I was under the impression, perhaps wrongly, that you wanted to keep "quadrant" and get rid of "legacy".  I don't know who else would know what "legacy" is supposed to mean, anyway.

Legacy means legacy: the way things used to work.

Edward