The fix for unsaved files has been merged into devel

33 views
Skip to first unread message

Edward K. Ream

unread,
Dec 16, 2019, 7:01:42 AM12/16/19
to leo-e...@googlegroups.com
The new code fixes #1451 and is a thorough rewrite of all undo-related code.  It's much simpler and robust than before.

I have been happily eating my own dog food for several days.  Please report any problems immediately.

I have updated code as necessary throughout Leo's core, all plugins, unitTest.leo and scripts.leo

Code changes

- All the dirtyVnodeList logic is gone. This collapses the complexity of all clients of Leo's undo code, a major simplification.

- Split c.setChanged(flag) into c.setChanged() & c.clearChanged(). The new api is simpler and more robust.  I'll soon update the cheat sheet, etc.

- p.setDirty now sets the roots of all external files dirty.  This is another big collapse in code complexity.

- Importers should no longer clear c.changed.  As I write this, I see some of this got reverted.  I'll fix this next.

Summary

There will be no going back to the old way.

Bugs might still exist. Fixes would be much easier in the new world.

Edward

gar

unread,
Dec 17, 2019, 11:28:07 PM12/17/19
to leo-e...@googlegroups.com
Great news! Thank you very much for that!

пн, 16 дек. 2019 г. в 15:01, Edward K. Ream <edre...@gmail.com>:
--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/67228855-aafa-456d-abfd-a03edc974a10%40googlegroups.com.

Edward K. Ream

unread,
Dec 18, 2019, 5:33:34 AM12/18/19
to leo-editor
On Tue, Dec 17, 2019 at 10:28 PM gar <gar...@gmail.com> wrote:
Great news! Thank you very much for that!

You're welcome.

Edward
Reply all
Reply to author
Forward
0 new messages