minor bug in mod_tempfname

0 views
Skip to first unread message

bobjack

unread,
May 9, 2008, 6:56:10 AM5/9/08
to leo-editor
If a headline ending in ... (ellipses) is an ancestor of a node to be
edited the file path formed is invalid (at least on windows vista), so
the node can not be edited.

Bob

Edward K. Ream

unread,
May 9, 2008, 8:14:19 AM5/9/08
to leo-e...@googlegroups.com
On Fri, May 9, 2008 at 5:56 AM, bobjack <bob...@post.com> wrote:

If a headline ending in ... (ellipses) is an ancestor of a node to be edited the file path formed is invalid (at least on windows vista), so the node can not be edited.

Hmm.  mod_tempfname has a problem.  If it filters out non-ascii unicode characters it will have problem with, say, Chinese file names.  So the naive plan of filtering all characters *except* the valid ascii characters is flawed.

Drat.  I suppose building in unicode smarts: filtering 'general punctuation' characters is needed.  See:

http://www.fileformat.info/info/unicode/char/2026/index.htm

I've put this on the list.

Edward

bobjack

unread,
May 14, 2008, 12:44:09 PM5/14/08
to leo-editor
I think I misled you there, I did not mean the character ellipses but
three ascii dots. I think it is related to the recent enhancements,
which do not produce a valid temp file path when there are several
consecutive dots (even if seperated by spaces).

Bob

Edward K. Ream

unread,
May 15, 2008, 9:37:48 AM5/15/08
to leo-e...@googlegroups.com
On Wed, May 14, 2008 at 11:44 AM, bobjack <bob...@post.com> wrote:

I think I misled you there, I did not mean the character ellipses but
three ascii dots.

Thanks for the clarification.  OTOH, I think the unicode issues must be addressed just the same.

Edward

TL

unread,
May 15, 2008, 5:08:41 PM5/15/08
to leo-editor
Same problem occurs in XP. Bill Gates doesn't like 2 or more periods
at the end of a directory name. Since I wrote this code, I'll fix
it. I'll remove the extra periods. Ok?

Sorry I didn't respond sooner. I didn't see this posting until
Edward's last reply.

TL

TL

unread,
Jun 4, 2008, 10:32:09 AM6/4/08
to leo-editor
The fix was added to the Trunk in Rev 484.

Fix: Dos/Windows systems don't accept directories ending in a period.
If a node ends in a period then an underscore is appended.

TL

Reply all
Reply to author
Forward
0 new messages