What does @svg do in VR?

27 views
Skip to first unread message

tbp1...@gmail.com

unread,
Aug 18, 2021, 5:58:26 PM8/18/21
to leo-editor
@ekr recently fielded a PR for "VR plugin crashes for @svg nodes (Qt6 only) #2134".  I sanitized VR3 for this situation myself not long ago.  The thing is, what is supposed to happen for an @svg node anyway?  The VR3 code, which was taken from VR, doesn't seem to work even with QT5.  And if you feed a node whose body starts with <svg> to a browser or browser panel (e.g., WebEngineView), the svg will be displayed as intended.

So what is an @svg node supposed to give us that is different from this?  Perhaps it's not actually needed any more?

Edward K. Ream

unread,
Aug 20, 2021, 11:30:41 AM8/20/21
to leo-editor
On Wed, Aug 18, 2021 at 4:58 PM tbp1...@gmail.com <tbp1...@gmail.com> wrote:
@ekr recently fielded a PR for "VR plugin crashes for @svg nodes (Qt6 only) #2134".  I sanitized VR3 for this situation myself not long ago.  The thing is, what is supposed to happen for an @svg node anyway? 

My apologies for the delay in responding.

The body of an @svg can contain either:

1. The xml text of an svg image, containing an <svg> element, or
2. The absolute path to an svg file.

Edward

tbp1...@gmail.com

unread,
Aug 20, 2021, 11:41:08 AM8/20/21
to leo-editor
Thank you.  I'll get VR3 to act this way.  Either way, there is no need any more for the QSvgWidget so far as I can see.  The WebEngineView browser widget will display the svg.

Edward K. Ream

unread,
Aug 20, 2021, 1:11:05 PM8/20/21
to leo-editor
On Fri, Aug 20, 2021 at 10:41 AM tbp1...@gmail.com <tbp1...@gmail.com> wrote:
Thank you.  I'll get VR3 to act this way.  Either way, there is no need any more for the QSvgWidget so far as I can see.  The WebEngineView browser widget will display the svg.

Provided it exists :-)

Edward

tbp1...@gmail.com

unread,
Aug 20, 2021, 1:15:50 PM8/20/21
to leo-editor
I'm thinking PyQt6 will get a QWebengineView before it gets a QSvgWidget...
Reply all
Reply to author
Forward
0 new messages