The next few days

34 views
Skip to first unread message

Edward K. Ream

unread,
Sep 25, 2021, 6:37:27 AM9/25/21
to leo-editor
Here are my plans for the next few days, before leaving on vacation Wednesday, Sept. 29.

Complete the mass cleaning of Leo's sources

This must be done now, early in the next release cycle. The code cleaning is being driven by enabling pylint's "format" checkers, which check for long lines, bad indentation, etc.

All of Leo's core files also pass with the multiple-statements checker enabled. After a bit of dithering, I've decided to clean all of Leo's files with the multiple-statements checker enabled. There are several reasons for this:

- Useful for coverage testing.
- Simulates what black would do.
  Leo's own "beautify" command does not split or join lines by default.
- I've grown to dislike cramming two statements on a line.

I'll likely finish this code cleaning in one or two days. This will be the end of code munging!

Start using leoInteg

I shall be using vs-code for at least a few minutes every day. I expect it will be several weeks before I am truly comfortable with vs code.

The picture I have is of gently pushing on a seemingly immovable wall. After a week or two it will suddenly tip over :-)

I'll start by customizing key bindings, syntax coloring and other parts of the look and feel. Along the way I'll report any bugs I find to Félix.

Edward

jkn

unread,
Sep 25, 2021, 6:46:44 AM9/25/21
to leo-editor
It's been a while since I looked, and maybe things are configurable,
but I remember not being impressed by what pylint told me was
'correct' indentation of split lines, on more than one occasion...

Edward K. Ream

unread,
Sep 25, 2021, 7:00:50 AM9/25/21
to leo-editor
On Sat, Sep 25, 2021 at 5:46 AM jkn <jkn...@nicorp.f9.co.uk> wrote:
It's been a while since I looked, and maybe things are configurable,
but I remember not being impressed by what pylint told me was
'correct' indentation of split lines, on more than one occasion...

I don't recall any such problems with pylint. Otoh, black is a serious offender re line breaks. Reminds me of this poem

When she was good,
She was very, very good,
But when she was bad, she was horrid.

:-)

Edward

tbp1...@gmail.com

unread,
Sep 25, 2021, 8:54:11 AM9/25/21
to leo-editor
"  I've decided to clean all of Leo's files with the multiple-statements checker enabled."  How would we do this for ourselves?



Edward K. Ream

unread,
Sep 25, 2021, 9:41:45 AM9/25/21
to leo-editor
On Sat, Sep 25, 2021 at 7:54 AM tbp1...@gmail.com <tbp1...@gmail.com> wrote:
"  I've decided to clean all of Leo's files with the multiple-statements checker enabled."  How would we do this for ourselves?

Rev b21ef3d in devel enables the multiple-statement checker.  Just run pylint on your file.

Note: I recently added `# pylint: disable=line-too-long,multiple-statements` at the top of VR3.  Remove this line if you want a full check.

Edward

Edward K. Ream

unread,
Sep 25, 2021, 11:29:01 AM9/25/21
to leo-editor
On Saturday, September 25, 2021 at 5:37:27 AM UTC-5 Edward K. Ream wrote:

I'll likely finish this code cleaning in one or two days.

  Done.  The recent improvement to the BackgroundProcessManager class makes it possibly to invoke pylint from inside Leo itself.

This will be the end of code munging!

I plan no further mass updates to Leo's code.

Edward
Reply all
Reply to author
Forward
0 new messages