PR #4639 merged into devel

[Edward K. Ream]

​Leo's "devel" branch now contains PR #4639. This PR is a milestone:

- The PR fixes a worthy bug that has bedeviled me for several weeks.

- The PR creates an excellent new code pattern: Leo's wrapper class for key events now creates inner wrappers (event.w) as necessary.

- Info item #1585 contains a manual checklist that devs should run whenever changing Leo's code in any way. Yes, it would be better for unit tests to run these checks automatically, but experience shows that creating such unit tests is far from easy.

- The PR cleans Leo's code in several ways. Four follow-on issues suggest other cleanups.

I want to thank Thomas for his comments on the PR. There's always time for more!

Please continue to test Leo's "devel" branch and report your experiences. Thanks!

Edward

[Thomas Passin]

The devel branch after this merge has a serious bug - tab completion of the minibuffer does *not* bring up the completion tab at all. Tabbing cycles through some candidate commands in the minibuffer single line edit but no Completion tab. This is the case on both Windows and Linux.

Also on Windows, the version has mysteriously gone backwards and doesn't include the rev and branch (Git says the rev is  cd042315bd).

Leo 6.8.7, October 11, 2025
Python 3.13.3, PyQt version 6.9.0
Windows 11 AMD64 (build 10.0.26200) SP0

On Linux, the version message looks normal:

Leo 6.8.9-devel, devel branch, build cd042315bd
2026-04-28 08:18:58 -0500
Python 3.12.3, PyQt version 6.9.0
linux

[Thomas Passin]

On Tuesday, April 28, 2026 at 10:20:13 AM UTC-4 Thomas Passin wrote:

Leo 6.8.7, October 11, 2025
Python 3.13.3, PyQt version 6.9.0
Windows 11 AMD64 (build 10.0.26200) SP0

This part was a false alarm. I had made a mistake the last time I modified my launch script.  The bug about the Completion tab not opening still stands.

[Edward K. Ream]

On Tue, Apr 28, 2026 at 9:20 AM Thomas Passin <tbp1...@gmail.com> wrote:

The devel branch after this merge has a serious bug - tab completion of the minibuffer does *not* bring up the completion tab at all. Tabbing cycles through some candidate commands in the minibuffer single line edit but no Completion tab. This is the case on both Windows and Linux.

Everything works for me on Windows.

Edward

[Edward K. Ream]

To repeat, everything works for me on Windows.

Edward

[Thomas Passin]

I have two Linux VMs. When I posted my report on the Completion tab not opening, I had tried it out on one of them. Now, I tried the other and the Completion tab opened as expected. I went back to the other VM, ran Leo again, and now the Completion tab opened too. One one of these VMs, Leo was opening with several tabs, on the other with only the Workbook. After going back and forth between the two VMs, and closing all the other outlines, the Completion pane continued to open in both VMs.

On Windows, I've had Leo opening with half a dozen outlines, and continued to not get the Completion tab. I opened a second instance that only opened the Workbook. The Completion tab opened in this instance.  I closed it and reopened the instance from this original console and now the Completion tab opens in it.

The only explanation I can find is that it must be possible for an outline to get slightly misconfigured somehow in a way that prevents the Completion tab from opening and that condition persists through a close-restart cycle. Once the condition gets cleared, Completion works as expected and that condition too persists,

How this could be possible I have no idea and I don't have any notion of how to troubleshoot. Now that things are behaving again all I can do is look for the behavior to recur again, if it does.

[Thomas Passin]

I have been able to reproduce this effect in a different Leo virtual environment, one that uses a different version of Python. First I ran a pip-installed earlier version of Leo, letting it open the same outlines as usual. In the Workbench, the Completion tab failed to open. Then in the same console and venv I ran the latest devel branch rev with the same suite of outlines. In the Workbook, the Completion tab failed to open. 

Then I switched to another outline tab and the Completion tab did open correctly. After that when I switched back to the Workbook, the Completion tab opened as expected.

I still don't grasp what is going on but I was able to reproduce the entire sequence.

[Edward K. Ream]

On Tue, Apr 28, 2026 at 12:17 PM Thomas Passin <tbp1...@gmail.com> wrote:

The only explanation I can find is that it must be possible for an outline to get slightly misconfigured somehow in a way that prevents the Completion tab from opening and that condition persists through a close-restart cycle. Once the condition gets cleared, Completion works as expected and that condition too persists,

How this could be possible I have no idea and I don't have any notion of how to troubleshoot. Now that things are behaving again all I can do is look for the behavior to recur again, if it does.

Thanks for this report. Is anyone else seeing something similar?

Have you tried clearing your caches?

Edward

[Thomas Passin]

I suspect it has something to do with the Python compiled code caches. I might try something along those lines if I can get it to happen again.

[lewis]

The Find tab is not working. See https://github.com/leo-editor/leo-editor/issues/4647

[Thomas Passin]

Confirm. Also the NAV tab fails when <ENTER> is typed. See 

https://github.com/leo-editor/leo-editor/issues/4648

[Edward K. Ream]

On Tue, Apr 28, 2026 at 4:57 PM lewis <lewi...@fastmail.com.au> wrote:

The Find tab is not working. See https://github.com/leo-editor/leo-editor/issues/4647

Thanks for your report. I'll fix it soon.

Edward

[Edward K. Ream]

On Tue, Apr 28, 2026 at 5:39 PM Thomas Passin <tbp1...@gmail.com> wrote:

Confirm. Also the NAV tab fails when <ENTER> is typed.

Thanks. Same crash.

Edward