Lewis Neal: pylint reports two undefined symbols in mod_http.py

42 views
Skip to first unread message

Edward K. Ream

unread,
Dec 8, 2019, 5:51:55 AM12/8/19
to leo-editor
I'm not sure what to do with this.  Iirc, pylint may not know about some symbols in asynchat.async_chat or SimpleHTTPRequestHandler.

There are two complaints, both about the do_POST method:

urlparse_header appears undefined in:

ctype, pdict = urlparse_header(self.headers.getheader('content-type'))

and urlparse_multipart appears undefined in:

query = urlparse_multipart(self.rfile, pdict)

Do you know anything about this?

Edward

lewis

unread,
Dec 8, 2019, 7:43:48 AM12/8/19
to leo-editor
I know nothing about the pylint complaints. I did not use use pylint or any other code check process on mod_http plugin changes.
This tells you something about my coding skills :) I did the minimum to get the plugin working again.

It's completely new to me but I'm happy to try using pylint and understand what the messages mean.

Regards
Lewis

Edward K. Ream

unread,
Dec 9, 2019, 6:21:06 AM12/9/19
to leo-editor
On Sun, Dec 8, 2019 at 6:43 AM lewis <lewi...@operamail.com> wrote:

I did the minimum to get the plugin working again.

It's completely new to me but I'm happy to try using pylint and understand what the messages mean.

I just want to know if you changed do_POST.  Hmm.  I should have looked at git blame and the PR diff first.

Let me take it from here.

Edward

lewis

unread,
Dec 9, 2019, 7:36:44 AM12/9/19
to leo-editor
Just had a chance to look at the code and I did make changes to the method:
def do_POST(self):

The 2 lines shown are part of the changes I made.

Regards
Lewis

Edward K. Ream

unread,
Dec 9, 2019, 6:33:40 PM12/9/19
to leo-editor
Assuming they work correctly, I'll just suppress the pylint complaints.

Edward
Reply all
Reply to author
Forward
0 new messages