The refs branch is ready for testing

28 views
Skip to first unread message

Edward K. Ream

unread,
Mar 7, 2020, 1:46:38 PM3/7/20
to leo-editor
This branch fixes #1232. It is based on devel, so it should be immune from the controversy surrounding the gnx branch.

The fix is conceptually straightforward. Within @clean files only, the new code disallows multiple section references on the same.  Imo, this is not only reasonable, it is likely the only possible solution. Indeed, the @clean read logic ends up putting all section references on their own lines anyway. That is, within @clean files, any text preceding or following a section reference will end up on a separate line. There is zero chance I would consider changing this.

There is only one slight drawback. The new code adds a new, required, arg to at.write. There is a slight possibility that this could break existing scripts or plugins. Imo, that's a risk worth taking. Other solutions would be more ugly.

Edward

Thomas Passin

unread,
Mar 7, 2020, 3:34:04 PM3/7/20
to leo-editor


On Saturday, March 7, 2020 at 1:46:38 PM UTC-5, Edward K. Ream wrote:
This branch fixes #1232. It is based on devel, so it should be immune from the controversy surrounding the gnx branch.
[snip]
 
There is only one slight drawback. The new code adds a new, required, arg to at.write. There is a slight possibility that this could break existing scripts or plugins. Imo, that's a risk worth taking. Other solutions would be more ugly.

Any change the new arg could be defaulted to work with older code?

Edward K. Ream

unread,
Mar 7, 2020, 4:30:42 PM3/7/20
to leo-editor
Sure. It could become a kwarg. But I would rather not do that, unless the new api causes real problems.

Edward
Reply all
Reply to author
Forward
0 new messages