PR #4637 merged into devel

19 views
Skip to first unread message

Edward K. Ream

unread,
Apr 27, 2026, 5:14:14 AM (4 days ago) Apr 27
to leo-editor
I have just merged PR #4637 into the devel branch. This PR contains substantial revisions to Leo's Qt gui code.

I'll wait at least a week before making (or approving) any other changes to the devel branch. Before doing much else, it's essential that we are all happy with Leo's gui code.

So please continue to test Leo and report any issues immediately.  Thanks.

Edward

Edward K. Ream

unread,
Apr 27, 2026, 5:22:29 AM (4 days ago) Apr 27
to leo-editor
On Monday, April 27, 2026 at 4:14:14 AM UTC-5 Edward K. Ream wrote:

I have just merged PR #4637 into the devel branch. This PR contains substantial revisions to Leo's Qt gui code.

So please continue to test Leo and report any issues immediately.  Thanks.

Expletives deleted: copy/paste do not work from the menu. Clearly, my testing protocol is wanting.  I'll see what I can do.

Edward

Edward K. Ream

unread,
Apr 27, 2026, 6:11:56 AM (4 days ago) Apr 27
to leo-editor
On Monday, April 27, 2026 at 4:22:29 AM UTC-5 Edward K. Ream wrote:

> copy/paste do not work from the menu...I'll see what I can do.

The failure arises from a confusion between event.w and event.widget. The former should be a wrapper, but it isn't when the user executes copy/paste from the menu.

A cff on event.widget shows some amazingly crazy code. This is a new area of focus for me, which is progress.

My apologies for my lack of testing.

Edward

Edward K. Ream

unread,
Apr 27, 2026, 10:29:59 AM (4 days ago) Apr 27
to leo-editor
On Monday, April 27, 2026 at 5:11:56 AM UTC-5 Edward K. Ream wrote:

>> copy/paste do not work from the menu...I'll see what I can do.
> The failure arises from a confusion between event.w and event.widget.

Work is going exceptionally well. PR #4639 is a milestone.

The breakthrough:  LeoKeyEvent.__init__ should create new wrappers only for Qt widgets! This simplification clarifies everything!

The PR changes 9 files, but five of those files do nothing but improve annotations. The changes in the other four files are small and easy to understand.

That's all for now. Stay tuned.

Edward

Viktor Ransmayr

unread,
Apr 27, 2026, 1:17:40 PM (4 days ago) Apr 27
to leo-e...@googlegroups.com
Hello Edward,

Am Mo., 27. Apr. 2026 um 16:30 Uhr schrieb Edward K. Ream <edre...@gmail.com>:
On Monday, April 27, 2026 at 5:11:56 AM UTC-5 Edward K. Ream wrote:

>> copy/paste do not work from the menu...I'll see what I can do.
> The failure arises from a confusion between event.w and event.widget.

I tested the 'devel' branch in a Fedora VM.

The tests only confirm what you alread know ;-) - That is:

* Copy / paste from 'completion' tab using keybindings IS working ...
* Copy / paste from 'completion' tab using edit menue is NOT working ...

Other than that my quick manual tests did not reveal anything else.

With kind regards,

Viktor

Edward K. Ream

unread,
Apr 27, 2026, 1:43:29 PM (4 days ago) Apr 27
to leo-e...@googlegroups.com
> The tests only confirm what you already know ;-) - That is:


> * Copy / paste from 'completion' tab using keybindings IS working ...
> * Copy / paste from 'completion' tab using edit menu is NOT working ...


> Other than that my quick manual tests did not reveal anything else.

Many thanks for your testing. PR #4639 is now complete, afaik.

All tests in the testing list (in the first comment) pass for me on Windows.

If you are willing, please pull the branch and test it. Thanks!

Edward

Viktor Ransmayr

unread,
Apr 27, 2026, 3:18:27 PM (4 days ago) Apr 27
to leo-e...@googlegroups.com
Hello Edward,

I tried out the 'ekr-fix-copy-paste-again' branch using Debian - and - copy / paste from 'completion' tab using edit menu is now also working !

With kind regards,

Viktor


Edward K. Ream

unread,
Apr 27, 2026, 6:17:07 PM (3 days ago) Apr 27
to leo-e...@googlegroups.com
On Mon, Apr 27, 2026 at 2:18 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

>> If you are willing, please pull the branch and test it. Thanks!
> I tried out the 'ekr-fix-copy-paste-again' branch using Debian - and - copy / paste from 'completion' tab using edit menu is now also working !

Excellent. Many thanks.

Edward
Reply all
Reply to author
Forward
0 new messages