Please test the ekr-qt branch (Qt6) *regardless* of your qt version

[Edward K. Ream]

The ekr-qt branch (PR #1881 for issue #1846) is ready for testing.

Please test this branch no matter what version of qt/pyqt you are using.  In fact, right now it's more important to test with qt5 and qt4.

Parts of the code are solid. Other parts, especially plugins, could cause Leo to take a hard crash. So please back up your work and save your files frequently.

Please report anything suspicious immediately.  I would like to have a week of testing at least before merging the ekr-qt branch into devel.

Edward

[Edward K. Ream]

On Saturday, April 10, 2021 at 3:25:29 PM UTC-5 Edward K. Ream wrote:

> The ekr-qt branch (PR #1881 for issue #1846) is ready for testing.

...

> I would like to have a week of testing at least before merging the ekr-qt branch into devel.

I plan to merge ekr-qt into devel this coming Monday, May 10.

Edward

[Viktor Ransmayr]

Hello Edward,

Just an initial feedback, that after a switch to this branch - and - very light tests I did not experience any issues on Fedora Linux 33.

With kind regards,

Viktor

PS: Here's the startup log of the current setup:

::

    Leo Log Window
    Leo 6.4-devel, ekr-qt branch, build 782c509813
    2021-05-06 08:18:33 -0500
    Python 3.9.4, PyQt version 5.15.2
    linux
    setting leoID from os.getenv('USER'): 'user'
    current dir: /home/user/PyVE/GitHub/Leo
    load dir: /home/user/PyVE/GitHub/Leo/leo-editor/leo/core
    global config dir: /home/user/PyVE/GitHub/Leo/leo-editor/leo/config
    home dir: /home/user
    reading settings in /home/user/PyVE/GitHub/Leo/leo-editor/leo/config/leoSettings.leo
    reading settings in /home/user/.leo/myLeoSettings.leo
    reading settings in /home/user/Documents/SL2021.leo
    read outline in 0.36 seconds
    reading settings in /home/user/.leo/myLeoSettings.leo

[Viktor Ransmayr]

Hello Edward,

Edward K. Ream schrieb am Samstag, 10. April 2021 um 22:25:29 UTC+2:

The ekr-qt branch (PR #1881 for issue #1846) is ready for testing.

As part of my light tests I also read #1846.

In there it is stated, that Leo still supports PyQt4.

Can you please explain to me how this is checked / verified?

From 'setup.py' on GitHub I would assume, that the minimum required version is PyQt 5.12. - See

* https://github.com/leo-editor/leo-editor/blob/master/setup.py

With kind regards,

Viktor

[tbp1...@gmail.com]

The branch is working for me, with no PyQt6 installed yet.   I haven't tried anything besides basic use, but so far, so good.

[tbp1...@gmail.com]

I just installed PyQt6.02 on Windows.  Leo opens and runs, but remember that weird behavior, where pressing the CNTL key deleted the selection and inserted strange characters?  I'm still getting variations of that in all panes, he exact details depend on which keys are pressed with CNTL.

Leo 6.4-devel, ekr-qt branch, build aba21c2a12

I got a series of font error messages:

DirectWrite: CreateFontFaceFromHDC() failed (Indicates an error in an input file such as a font file.) for QFontDef(Family="8514oem", pointsize=9.75, pixelsize=20, styleHint=5, weight=400, stretch=100, hintingPreference=0) LOGFONT("8514oem", lfWidth=0, lfHeight=-20) dpi=120

  OpenType support missing for "Consolas", script 32

  OpenType support missing for "DejaVu Sans Mono", script 32

  OpenType support missing for "Arial", script 32

  OpenType support missing for "MS UI Gothic", script 32

  OpenType support missing for "SimSun", script 32

  OpenType support missing for "Arial Unicode MS", script 32

  OpenType support missing for "Segoe UI Emoji", script 32

  OpenType support missing for "Segoe UI Symbol", script 32

[Edward K. Ream]

On Fri, May 7, 2021 at 2:46 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

> Just an initial feedback, that after a switch to this branch - and - very light tests I did not experience any issues on Fedora Linux 33.

Thanks for testing.

Edward

[Edward K. Ream]

On Fri, May 7, 2021 at 3:33 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

> In [#1846] it is stated, that Leo still supports PyQt4.

> Can you please explain to me how this is checked / verified?

Iirc, there are no explicit tests that the code works with Qt4. However, I made no functional changes to the code except additions for Qt6. So if the code works with Qt5 it should also work with Qt4.

Edward

[Edward K. Ream]

On Sat, May 8, 2021 at 10:48 PM tbp1...@gmail.com <tbp1...@gmail.com> wrote:

The branch is working for me, with no PyQt6 installed yet.   I haven't tried anything besides basic use, but so far, so good.

Thanks for your feedback.

Edward

[Edward K. Ream]

On Sat, May 8, 2021 at 11:07 PM tbp1...@gmail.com <tbp1...@gmail.com> wrote:

I just installed PyQt6.02 on Windows.  Leo opens and runs, but remember that weird behavior, where pressing the CNTL key deleted the selection and inserted strange characters?  I'm still getting variations of that in all panes, he exact details depend on which keys are pressed with CNTL.

Leo 6.4-devel, ekr-qt branch, build aba21c2a12

I got a series of font error messages:

Thanks for this report. Clearly, not all is well with the Qt6 code. Otoh, the workaround will be to install Qt5, so I still plan to merge the ekr-qt branch into devel tomorrow.

Edward

[tbp1...@gmail.com]

As to the bad characters being injected, I wrote a tiny pyqt6 app with only a text edit widget, not even a main window.  It did not have the anomalous behavior, and the key codes it returned were as expected.  That makes it seem that Leo is doing something, not the Qt widgets.

[tbp1...@gmail.com]

From scanning the web, it seems that the unsupported font problem may  be related to Qt using DirectWrite.  With QT on its own, there may be a way to disable it.  With pyqt6, it is likely to be something that has been compiled in (though I'm not sure).  

Since my standard Consolas font doesn't work with the current PyQt6, the fallback is used, which may be Courier New - I'm not sure but I don't like it much, whatever it is.

[tbp1...@gmail.com]

I see the same issues on my linux installation - including the weird keyboard behavior.  I didn't see error messages about fonts, though.

[Edward K. Ream]

On Sun, May 9, 2021 at 10:34 AM tbp1...@gmail.com <tbp1...@gmail.com> wrote:

I see the same issues on my linux installation - including the weird keyboard behavior.  I didn't see error messages about fonts, though.

Thanks for all this testing. For now, I suggest using Qt5 for real work.

Edward