python 2 remnants: create an issue for each or...?

32 views
Skip to first unread message

Matt Wilkie

unread,
Nov 19, 2019, 1:34:52 PM11/19/19
to leo-editor
I noticed a function[0] today that was created to simulate python 3, which is no longer necessary now that py2 support has been dropped. There's probably dozens of these scattered throughout. How should they be flagged for refactoring and/or removal? Create an issue for each one or collect them into one, or something else?

[0] LeoPyRef.leo#Code-->Core classes-->@file leoGlobals.py-->g.Scripting-->g.exec_file

-matt

Edward K. Ream

unread,
Nov 19, 2019, 2:02:25 PM11/19/19
to leo-editor
On Tue, Nov 19, 2019 at 12:34 PM Matt Wilkie <map...@gmail.com> wrote:
I noticed a function[0] today that was created to simulate python 3, which is no longer necessary now that py2 support has been dropped. There's probably dozens of these scattered throughout. How should they be flagged for refactoring and/or removal? Create an issue for each one or collect them into one, or something else?

Please collect them in a single issue.  Not all can be fixed, because the wrapper function doesn't do exactly the same thing as the actual python function.

Having said that, I definitely do want to clean what can be cleaned.

Edward

Matt Wilkie

unread,
Nov 21, 2019, 4:34:07 PM11/21/19
to leo-editor
Reply all
Reply to author
Forward
0 new messages