PR #4767 (revised leoNodes.py) merged into devel

11 views
Skip to first unread message

Edward K. Ream

unread,
9:26 AM (13 hours ago) 9:26 AM
to leo-editor
PR #4767 is now in Leo's devel branch. The PR contains code-level improvements to one of Leo's most important files: leoNodes.py. See the PR for full details.

I have been eating my own dog food for several days, but mistakes do happen. Please report any problems immediately.  Thanks.

Edward

Edward K. Ream

unread,
1:48 PM (8 hours ago) 1:48 PM
to leo-e...@googlegroups.com
On Sat, July 4, 2026 at 8:27 AM Edward K. Ream wrote:

PR #4767 is now in Leo's devel branch. The PR contains code-level improvements to one of Leo's most important files: leoNodes.py. See the PR for full details.

Thomas rightly asked why I merged the PR without approval. When I said in the PR that there was no rush, I meant that reviewers could take their time.

However, this PR (and those to follow) are inherently sequential. Each depends on the previous one. Waiting days for review will significantly slow the overall process.

Furthermore, it's unlikely that reviewers will find a significant bug that mypy, pylint, flake8, and Leo's unit tests all failed to uncover. Sure, that's possible, but I'm willing to take that chance. I'll fix any such bug immediately in a much smaller PR. 

The next PR, #4772, is also ready for review.  I'll merge that PR today so that I can turn my attention to leoCommands.py.
Summary

For the next week or two, the "devel" branch could plausibly be said to be more unstable than usual.

If that situation bothers you, you can just wait for the dust to settle.

Edward
Reply all
Reply to author
Forward
0 new messages