external file change detection

56 views
Skip to first unread message

Félix

unread,
May 27, 2021, 9:36:46 PM5/27/21
to leo-editor
Am I wrong in noticing that a couple weeks ago, if Leo detected an external file change, it would not matter how many times I modified the file before I responded to the dialog asking me what to do about it?

Seems that for a while now, if I modify it more than once, it asks me again if I want to reload / ignore it...? 

Sorry I cant provide an exact version or moment this started happening.

--
Félix

Edward K. Ream

unread,
May 28, 2021, 9:23:24 AM5/28/21
to leo-editor
On Thu, May 27, 2021 at 8:36 PM Félix <felix...@gmail.com> wrote:
Am I wrong in noticing that a couple weeks ago, if Leo detected an external file change, it would not matter how many times I modified the file before I responded to the dialog asking me what to do about it?

I'm not sure I understand your question.

Seems that for a while now, if I modify it more than once, it asks me again if I want to reload / ignore it...? 

Sorry I cant provide an exact version or moment this started happening.

I scanned the history using gitk leo/core/externalFiles.py:

- Rev 1c96c74e851, April 27, does contain a significant change. Not sure exactly what it was meant to do.

- Rev 49ae729b21, Dec 13 of last year also has a real change.

How does the external files code affect leoInteg?

Edward

Félix

unread,
May 28, 2021, 10:09:03 AM5/28/21
to leo-editor
This has nothing to do with leoInteg.

step to reproduce: 
modify an external file, save it, notice Leo will popup his dialog, but dont answer it....
modify the file again, save it, - (now the file has been modiffied more than once...) 

Now answer the dialogin leo (say yes to pickup changes)... Leo pops the dialog again! 

it does not pop it again if the file was modified once, then the dialog answered (before modifying again).
--
Félix

Sorry for my english ;)

Edward K. Ream

unread,
May 28, 2021, 11:43:58 AM5/28/21
to leo-editor
On Fri, May 28, 2021 at 9:09 AM Félix <felix...@gmail.com> wrote:
This has nothing to do with leoInteg.

Good :-)

step to reproduce: 
modify an external file, save it, notice Leo will popup his dialog, but dont answer it....
modify the file again, save it, - (now the file has been modiffied more than once...) 

Now answer the dialogin leo (say yes to pickup changes)... Leo pops the dialog again! 

it does not pop it again if the file was modified once, then the dialog answered (before modifying again).

Thanks for the clear explanation.  I have just created #1961 for this issue.  I'll look into it next.

Edward

Edward K. Ream

unread,
May 28, 2021, 1:59:30 PM5/28/21
to leo-editor
On Fri, May 28, 2021 at 10:43 AM Edward K. Ream <edre...@gmail.com> wrote:

> I have just created #1961 for this issue.

PR #1962 contains a one-line fix. I have merged the new code into devel.

Edward

Félix

unread,
May 28, 2021, 3:56:49 PM5/28/21
to leo-editor
Great! Thanks!

Edward K. Ream

unread,
May 28, 2021, 4:51:07 PM5/28/21
to leo-editor


On Fri, May 28, 2021 at 2:56 PM Félix <felix...@gmail.com> wrote:
Great! Thanks!

You're welcome. I was pleased with the fix.

Edward
Reply all
Reply to author
Forward
0 new messages