PR #4649 fixes problems in find and nav panes

18 views
Skip to first unread message

Edward K. Ream

unread,
Apr 29, 2026, 5:37:57 AM (2 days ago) Apr 29
to leo-editor
PR #4649 (in the ekr-4647-find-tab branch) seems to fix the latest reported problems.

Please pull the branch and test it for yourself.

I'm not satisfied with all the special cases in LeoKeyEvent.__init__. I'm working on gaining more insight.

Edward

lewis

unread,
Apr 29, 2026, 6:24:02 AM (2 days ago) Apr 29
to leo-editor
Hi Edward,

I tried:
$ git checkout cdcee46
error: pathspec 'cdcee46' did not match any file(s) known to git

Am I using the right git command? Apologies,  I do this infrequently and need a reminder :)

Regards
Lewis

lewis

unread,
Apr 29, 2026, 6:53:49 AM (2 days ago) Apr 29
to leo-editor
All ok :)

$ git branch ekr-4647-find-tab
then
$ git checkout ekr-4647-find-tab

Running ekr-4647-find-tab branch, build b11e85a3dd
I can confirm there is no crash in the Find Tab or Nav Tab 

Edward K. Ream

unread,
Apr 29, 2026, 10:22:44 AM (2 days ago) Apr 29
to leo-e...@googlegroups.com
On Wed, Apr 29, 2026 at 5:53 AM lewis <lewi...@fastmail.com.au> wrote:

Running ekr-4647-find-tab branch, build b11e85a3dd
I can confirm there is no crash in the Find Tab or Nav Tab 

Thanks for your testing.

What do you think? Should I merge it today?

Edward

lewis

unread,
Apr 29, 2026, 11:06:48 AM (2 days ago) Apr 29
to leo-editor
Yes, the Find pane accepts input and found the text entered. Nav pane worked with no errors.

Edward K. Ream

unread,
Apr 29, 2026, 1:49:54 PM (2 days ago) Apr 29
to leo-e...@googlegroups.com
On Wed, Apr 29, 2026 at 10:06 AM lewis <lewi...@fastmail.com.au> wrote:
Yes, the Find pane accepts input and found the text entered. Nav pane worked with no errors.

Thanks for your testing! I'm dithering about when to merge the new PR: I may delay the merge a bit to facilitate further testing. I'll say more about testing in another ENB.

If anyone is in a hot rush, they can always check out the master branch, the official branch of Leo 6.8.8. That will revert a lot of work, but there have been no reports of bugs against 6.8.8.

Edward
Reply all
Reply to author
Forward
0 new messages