Bookmarks plugin

[lewis]

Hi Terry,

Enjoying using your bookmarks plugin, it's very useful for quick navigation both within and between different files.

I have recently noticed it allows you to add duplicate bookmarks in a node. It doesn't flash the existing bookmark red as shown in your bookmarks video (4:55).
Maybe it has always been possible to add a duplicate but the red warning isn't happening now.

Regards
Lewis

Leo Log Window
Leo 5.4-devel, build 20160722143100, Fri, Jul 22, 2016  2:31:00 PM
Git repo info: branch = master, commit = aca8d416ec35
Python 2.7.12, PyQt version 4.8.7
Windows 10 AMD64 (build 10.0.10586)

[Terry Brown]

On Sun, 28 Aug 2016 06:14:12 -0700 (PDT)
lewis <lewi...@operamail.com> wrote:

> Hi Terry,
>
> Enjoying using your bookmarks plugin, it's very useful for quick
> navigation both within and between different files.
>
> I have recently noticed it allows you to add duplicate bookmarks in a
> node. It doesn't flash the existing bookmark red as shown in your

> bookmarks video <https://vimeo.com/77720098> (4:55).

> Maybe it has always been possible to add a duplicate but the red
> warning isn't happening now.

Heh, that feature got dropped, but I'd like it back myself, and let's
face it, it's easier to fix the feature than the video :-)

So I will try and put it back soon.

Thanks for the feedback.

Cheers -Terry

> Regards
> Lewis
>
> *Leo Log WindowLeo 5.4-devel, build 20160722143100, Fri, Jul 22,
> 2016 2:31:00 PMGit repo info: branch = master, commit =

> aca8d416ec35Python 2.7.12, PyQt version 4.8.7Windows 10 AMD64 (build

> 10.0.10586) *

[Terry Brown]

I have some code that restores the red highlighting, but also fiddles around a lot with displaying empty bookmark folders (which you'd add bookmarks to), nothing new but works with less input now.

But I'm going to be off line for a week and don't want to push the new code without further testing, so Lewis if you want to check it out from my fork https://github.com/tbnorth/leo-dev-tbnorth that would be great otherwise I'll eat my own dogfood for a bit when I have more time next week.

Cheers -Terry

---

From: 'Terry Brown' via leo-editor <leo-e...@googlegroups.com>
To: leo-e...@googlegroups.com
Sent: Sunday, August 28, 2016 4:56 PM
Subject: Re: Bookmarks plugin

--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+unsub...@googlegroups.com.
To post to this group, send email to leo-e...@googlegroups.com.
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

[Terry Brown]

I've just pushed the code that restores the red highlighting, and handles empty bookmark "folders" (organizer nodes) better. Haven't seen any problems with it.

Note that the detection of duplicate bookmarks only works when they're identical, the UNLs 

file://D:\local\workbook.leo#non-synth%20time:4

and 

file://D:\local\workbook.leo#non-synth%20time:6

may resolve to the same node  (assuming it moved down the outline over time), but bookmarks won't recognize them as dupes.

We could use the UNL mode that doesn't include numbers, but then it can only mark the first of N nodes with the same headline, so that seems a poor trade off.

I think in general it won't be a problem, you tend to use bookmarks for nodes in active use and they tend not to change position too much.

Cheers -Terry

---

From: 'Terry Brown' via leo-editor <leo-e...@googlegroups.com>

To: "leo-e...@googlegroups.com" <leo-e...@googlegroups.com>
Sent: Tuesday, August 30, 2016 5:12 PM
Subject: Re: Bookmarks plugin

To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.

[lewis]

Hi Terry,

Thanks for the update. The red highlighting of a duplicate bookmark works fine.

I noticed a very minor quirk:
When you have the bookmark node expanded (outline pane), pressing the bookmark pane to add a bookmark does not update the node list. The node needs to be collapsed and expanded to see the updated list. However if you hover over a bookmark button> Rt-click> [Delete bookmark], the node list updates immediately.
It's very subtle but noticeable difference in behaviour.

Regards
Lewis

On Tuesday, 13 September 2016 00:22:36 UTC+10, Terry Brown wrote: