Leo 6.7.4 is code complete. Please test

Edward K. Ream

unread,

Jul 15, 2023, 8:22:47 AM7/15/23

to leo-editor

This morning I merged two PRs and fixed a few problems directly in devel:

- PR #3438 contains the new undo code. See the first comment of the PR for details.

- PR #3437 fixes a few quirps reported by Félix.

- One new unit test was randomly spewing messages from git.

I renamed the test so it doesn't run by default.

Summary

6.7.4 is code complete. Please test the devel branch.

Edward

Edward K. Ream

unread,

Jul 15, 2023, 5:09:42 PM7/15/23

to leo-editor

On Saturday, July 15, 2023 at 7:22:47 AM UTC-5 Edward K. Ream wrote:

> - PR #3438 contains the new undo code. See the first comment of the PR for details.

The PR implements an important new principle: executing a non-undoable command should clear Leo's undo state by calling u.clearAndWarn.

Many thanks to Félix for setting me right. Not following this principle was likely the source of subtle problems in Leo.

Edward

Edward K. Ream

unread,

Jul 15, 2023, 5:12:14 PM7/15/23

to leo-editor

On Saturday, July 15, 2023 at 7:22:47 AM UTC-5 Edward K. Ream wrote:

> 6.7.4 is code complete. Please test the devel branch.

I expect to release 6.7.4 on this Friday, July 21, as scheduled.

However, there would be no harm in delaying the release should problems arise.

Edward

Thomas Passin

unread,

Jul 15, 2023, 5:20:21 PM7/15/23

to leo-editor

Are these changes merged into the 6.7.4 branch yet? IOW, should we be trying out devel or 6.7.4

Edward K. Ream

unread,

Jul 15, 2023, 6:28:59 PM7/15/23

to leo-e...@googlegroups.com

On Sat, Jul 15, 2023 at 4:20 PM Thomas Passin <tbp1...@gmail.com> wrote:

Are these changes merged into the 6.7.4 branch yet? IOW, should we be trying out devel or 6.7.4

Good question. Both branches contain the same code. You can test in either branch.

The 6.7.4 will soon contain distribution-related changes.

Edward

Viktor Ransmayr

unread,

Jul 16, 2023, 3:40:37 PM7/16/23

to leo-editor

Hello Edward,

Edward K. Ream schrieb am Samstag, 15. Juli 2023 um 14:22:47 UTC+2:

...

6.7.4 is code complete. Please test the devel branch.

I have successfully tested Leo's devel branch in a Debian 11 & a Fedora 38 Linux-VM.

Other than the larger number of skipped unit tests, I have not noticed anything ...

With kind regards,

Viktor

Edward K. Ream

unread,

Jul 16, 2023, 4:13:31 PM7/16/23

to leo-e...@googlegroups.com

On Sun, Jul 16, 2023 at 2:40 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

I have successfully tested Leo's devel branch in a Debian 11 & a Fedora 38 Linux-VM.

Other than the larger number of skipped unit tests, I have not noticed anything ...

Thanks for your testing. I've noticed the surprising number of skipped tests and will investigate.

Edward

Edward K. Ream

unread,

Jul 16, 2023, 4:17:19 PM7/16/23

to leo-e...@googlegroups.com

On Sun, Jul 16, 2023 at 2:40 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

> Other than the larger number of skipped unit tests, I have not noticed anything ...

Running the unit tests with the -v option shows that the skipped tests arise from test_set_setting.

For example: skipped "TestPython is not 'LeoUnitTest'"

In other words, test_set_setting wasn't a clever idea :-) I'll fix this.

Edward

Edward K. Ream

unread,

Jul 16, 2023, 4:40:19 PM7/16/23

to leo-editor

On Sunday, July 16, 2023 at 3:17:19 PM UTC-5 Edward K. Ream wrote:

In other words, test_set_setting wasn't a clever idea :-) I'll fix this.

Done via PR #3443. Merged into devel and 6.7.4 branches.

This change eliminates all skipped tests on my Windows machine.

Edward

Reply all

Reply to author

Forward