PR #4845 is now in the "devel" branch

[Edward K. Ream]

PR #4845 runs all unit tests using Leo's null gui, sacrificing four tests that require Leo's Qt gui. These tests are no great loss. In any case, I see no alternative.

I merged this PR without any formal review, but I welcome your comments, questions, and suggestions at any time.

The lack of formal review does not trouble me in this case. The PR was urgently needed. We can easily fix any problems should they arise.

Please keep testing "devel"!

Edward

[Edward K. Ream]

On Wednesday, August 5, 2026 at 6:19:36 AM UTC-5 Edward K. Ream wrote:

> I merged this PR without any formal review...The lack of formal review does not trouble me in this case.

I'd like to reassure those who might be concerned about this "cowboy" approach.

The great thing about PRs is that they are a permanent record of all changes made, including all the individual commits that make up the PR. This record is invaluable if problems arise or if devs have concerns about the PR.

In short, PRs minimize the risk of all code changes.

Edward

[Ville M. Vainio]

And if you have a CI, PR is an easy way to ensure all checks pass before code lands in main

--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/leo-editor/596296b3-9598-41d1-898c-2bb5555e5a82n%40googlegroups.com.

[Edward K. Ream]

On Wed, Aug 5, 2026 at 8:17 AM Ville M. Vainio <viva...@gmail.com> wrote:

And if you have a CI, PR is an easy way to ensure all checks pass before code lands in main

Exactly. Leo's checks have been in flux recently, but we'll get it sorted.

Edward

[Viktor Ransmayr]

Hello Edward,

They will - but - for the moment we still see the error I reported earlier ;-)

    ...

    OK (skipped=3)
    mypy_leo.py
    leo/plugins/todo.py:543: error: Incompatible default for argument "prog" (default has type "int | str", argument has type "int")  [assignment]
    Found 1 error in 1 file (checked 258 source files)
    ruff_leo.py
    ... 

Viktor

[Edward K. Ream]

On Wed, Aug 5, 2026 at 2:16 PM Viktor Ransmayr wrote:

>  for the moment we still see the error I reported earlier ;-)

You can ignore the warning in todo.py. I'm about to retire that plugin.

Edward