PR #4328 merged into devel

[Edward K. Ream]

PR #4328 changes the color-and-font-related settings that tell Leo how to colorize reStructuredText. This PR changes only leoSettings.leo. The first comment of the PR explains the changes and their rationale.

This PR aims to make Leo 6.8.4 and 6.8.3 functionally identical as far as these settings are concerned. But I may be mistaken. If necessary, I will be happy to make further changes in a new PR. Please report any remaining problems.

Edward

[Viktor Ransmayr]

Hello Edward,

Am So., 13. Apr. 2025 um 17:18 Uhr schrieb Edward K. Ream <edre...@gmail.com>:

PR #4328 changes the color-and-font-related settings that tell Leo how to colorize reStructuredText. This PR changes only leoSettings.leo. The first comment of the PR explains the changes and their rationale.

This PR aims to make Leo 6.8.4 and 6.8.3 functionally identical as far as these settings are concerned. But I may be mistaken. If necessary, I will be happy to make further changes in a new PR. Please report any remaining problems.

I did more tests with your latest updates to the 'devel' branch.

It has changed - but - it is not identical.

See attached screenshots for the test-outline I sent earlier in newly installed Leo environments !

For me personally it is already good enough, since the default coloring of reStructuredText nodes is no longer RED ...

It's your call to make, if the goal is to achieve identical look & feel for 6.8.4 or not ?

With kind regards,

Viktor

---

[Edward K. Ream]

On Mon, Apr 14, 2025 at 5:07 AM Viktor Ransmayr <viktor....@gmail.com> wrote:

I did more tests with your latest updates to the 'devel' branch.

It has changed - but - it is not identical.

Thanks for this report.

I see the problem you describe and have just created issue #4331.

For me personally it is already good enough, since the default coloring of reStructuredText nodes is no longer RED ...

It's your call to make, if the goal is to achieve identical look & feel for 6.8.4 or not ?

Imo, 6.8.3 and 6.8.4 should, without doubt, be identical (by default) in this regard.

Settings are complex and confusing enough without unnecessary complications.

BTW, I finally understood that disabling myLeoSettings (as you have done) is essential for separating default settings from user settings.

Edward

[Edward K. Ream]

On Monday, April 14, 2025 at 7:11:01 AM UTC-5 Edward K. Ream wrote:

> I see the problem you [Viktor] describe and have just created issue #4331.

PR #4332 is ready for review. I have tested this PR with and without an enabled version of myLeoSettings.

Please test and report any problems.

Edward

[Viktor Ransmayr]

Hello Edward,

Not yet identical ! - For me only ?

I tested it in the ALMOST fresh installation of my previous Leo 6.8.4 environment.

That is without a 'myLeoSettings.leo' outline - and - only the branch switched from 'devel' to 'ekr-4331-rest-coloring-2' ...

See attached screenshot.

With kind regards,

Viktor

[Edward K. Ream]

On Mon, Apr 14, 2025 at 11:33 AM Viktor Ransmayr <viktor....@gmail.com> wrote:

Hello Edward,

Am Mo., 14. Apr. 2025 um 16:45 Uhr schrieb Edward K. Ream <edre...@gmail.com>:

On Monday, April 14, 2025 at 7:11:01 AM UTC-5 Edward K. Ream wrote:

> I see the problem you [Viktor] describe and have just created issue #4331.

PR #4332 is ready for review. I have tested this PR with and without an enabled version of myLeoSettings.

Please test and report any problems.

Not yet identical ! - For me only ?

The screenshot is the intended result of PR #4332.

There may be some edge cases, but I think the solution now is add all the new settings (from the new PR) to your myLeoSettings.leo file and (if necessary) whatever theme file that your myLeoSettings.leo file selects.

In other words, I think the new PR is all I can do. Can you live with the new PR?

Edward

[Viktor Ransmayr]

Hello Edward,

Am Mo., 14. Apr. 2025 um 21:24 Uhr schrieb Edward K. Ream <edre...@gmail.com>:

On Mon, Apr 14, 2025 at 11:33 AM Viktor Ransmayr <viktor....@gmail.com> wrote:

Am Mo., 14. Apr. 2025 um 16:45 Uhr schrieb Edward K. Ream <edre...@gmail.com>:

On Monday, April 14, 2025 at 7:11:01 AM UTC-5 Edward K. Ream wrote:

> I see the problem you [Viktor] describe and have just created issue #4331.

PR #4332 is ready for review. I have tested this PR with and without an enabled version of myLeoSettings.

Please test and report any problems.

Not yet identical ! - For me only ?

The screenshot is the intended result of PR #4332.

I'm a bit puzzled ! - The only difference I can see is that the reStructuredText is now in a single color only. - See

* Earlier screenshot from 'devel' branch - and -

* later screenshot from 'ekr-4331-rest-coloring-2' branch

attached again for convenience.

There may be some edge cases, but I think the solution now is add all the new settings (from the new PR) to your myLeoSettings.leo file and (if necessary) whatever theme file that your myLeoSettings.leo file selects.

In other words, I think the new PR is all I can do. Can you live with the new PR?

As I stated previously: For me it was already good enough before.

[Edward K. Ream]

On Mon, Apr 14, 2025 at 2:55 PM Viktor Ransmayr <viktor....@gmail.com> wrote:

> I'm a bit puzzled ! - The only difference I can see is that the reStructuredText is now in a single color only.

Imo, that's the best Leo can do. It would be unwise to change the setting

  @color operator-color = None

because that setting is the default for all languages.

The ramifications are beyond my complete understanding. As a result, I am planning to announce the relevant changes as breaking changes between Leo 6.8.3 and 6.8.4. My recommendation is to add the @color rest.xxx setting to myLeoSettings.leo and/or any active theme files.

Viktor, does this seem like a reasonable plan to you?

Edward

[Viktor Ransmayr]

Hello Edward,

Yes. 

With kind regards, 

Viktor 

[Edward K. Ream]

On Tue, Apr 15, 2025 at 9:15 AM Viktor Ransmayr  wrote:

The ramifications are beyond my complete understanding. As a result, I am planning to announce the relevant changes as breaking changes between Leo 6.8.3 and 6.8.4. My recommendation is to add the @color rest.xxx setting to myLeoSettings.leo and/or any active theme files.

Viktor, does this seem like a reasonable plan to you?

Yes. 

Excellent. I'll merge PR #4332 soon.

Edward

[jkn]

How is "disabling myLeoSettings.leo" achieved, please?

    Thanks

    J^n

[Viktor Ransmayr]

Hello J^n,

Am Di., 15. Apr. 2025 um 19:51 Uhr schrieb jkn <jkn...@nicorp.f9.co.uk>:

How is "disabling myLeoSettings.leo" achieved, please?

One way is to rename it, e.g. to 'myLeoSettings.eol' ...

With kind regards,

Viktor

[jkn]

Thanks Victor (I like the 'eol' result). I thought perhaps there was some 'clever' way

to do this, but your way is of course perfectly adequate.

     Regards

     J^n

[Thomas Passin]

Or go to the @settings node and change its headline to @@settings.

[jkn]

On Tuesday, April 15, 2025 at 9:29:54 PM UTC+1 tbp1...@gmail.com wrote:

Or go to the @settings node and change its headline to @@settings.

right (I prefer that method, I think)

    J^n

[Viktor Ransmayr]

Hello J^n,

Am Di., 15. Apr. 2025 um 22:09 Uhr schrieb jkn <jkn...@nicorp.f9.co.uk>:

On Tuesday, April 15, 2025 at 7:33:11 PM UTC+1 viktor....@gmail.com wrote:

Hello J^n,

Am Di., 15. Apr. 2025 um 19:51 Uhr schrieb jkn <jkn...@nicorp.f9.co.uk>:

How is "disabling myLeoSettings.leo" achieved, please?

One way is to rename it, e.g. to 'myLeoSettings.eol' ...

...

Thanks Victor (I like the 'eol' result).

...

And my reply even contained a typo, i.e., I meant to write 'myLeoSettings.oel' ;-)

With kind regards,

Viktor

[Viktor Ransmayr]

Hello J^n,

I agree. -  Thanks to Leo's 'restart-leo' command, TBP's method even works without 'leaving' Leo !

* Disable '@settings' tree in 'myLeoSettings.leo' & restart Leo - OK? - YES.
* Enable '@settings' tree in 'myLeoSettings.leo' & restart Leo a second time - OK? - YES.

Just wanted to test it, before replying here ...

With kind regards,

Viktor

[Edward K. Ream]

On Wed, Apr 16, 2025 at 2:02 AM Viktor Ransmayr <viktor....@gmail.com> wrote:

Hello J^n,

jkn schrieb am Dienstag, 15. April 2025 um 23:01:22 UTC+2:

On Tuesday, April 15, 2025 at 9:29:54 PM UTC+1 tbp1...@gmail.com wrote:

Or go to the @settings node and change its headline to @@settings.

right (I prefer that method, I think)

I agree. -  Thanks to Leo's 'restart-leo' command, TBP's method even works without 'leaving' Leo !

I like this trick. Its drawback is that Leo's log reports that Leo is using myLeoSettings.leo. That message might be confusing.

Edward

[Thomas Passin]

On Wednesday, April 16, 2025 at 4:51:47 AM UTC-4 Edward K. Ream wrote:

I like this trick. Its drawback is that Leo's log reports that Leo is using myLeoSettings.leo. That message might be confusing.

I've never used Leo's log.  Where is it? Does it have to be enabled?

[Edward K. Ream]

I've never used Leo's log.  Where is it? Does it have to be enabled?

I meant Leo's log pane.

Edward

[jkn]

On Wednesday, April 16, 2025 at 8:02:15 AM UTC+1 viktor....@gmail.com wrote:

Hello J^n,

jkn schrieb am Dienstag, 15. April 2025 um 23:01:22 UTC+2:

On Tuesday, April 15, 2025 at 9:29:54 PM UTC+1 tbp1...@gmail.com wrote:

Or go to the @settings node and change its headline to @@settings.

right (I prefer that method, I think)

I agree. -  Thanks to Leo's 'restart-leo' command, TBP's method even works without 'leaving' Leo !

* Disable '@settings' tree in 'myLeoSettings.leo' & restart Leo - OK? - YES.
* Enable '@settings' tree in 'myLeoSettings.leo' & restart Leo a second time - OK? - YES.

Hi Victor

    Where do these 'prompts' come from please? (I am not very familiar with the restart-leo command/feature)

Thanks, J^n

[Viktor Ransmayr]

Hello J^n,

I  am  not sure, if I understand your question correctly. 

Those 'prompts' are just my notes, which I use to document my work / thoughts in Leo outlines since a long time  ...

I don't remember when & how I first found out about the 'restart-leo' command. 

Most likely Edward mentioned it here in the forum ...

With kind regards,

Viktor

[jkn]

On Thursday, April 17, 2025 at 10:24:29 AM UTC+1 viktor....@gmail.com wrote:

Hello J^n,

jkn <jkn...@nicorp.f9.co.uk> schrieb am Do., 17. Apr. 2025, 11:05:

On Wednesday, April 16, 2025 at 8:02:15 AM UTC+1 viktor....@gmail.com wrote:

Hello J^n,

jkn schrieb am Dienstag, 15. April 2025 um 23:01:22 UTC+2:

On Tuesday, April 15, 2025 at 9:29:54 PM UTC+1 tbp1...@gmail.com wrote:

Or go to the @settings node and change its headline to @@settings.

right (I prefer that method, I think)

I agree. -  Thanks to Leo's 'restart-leo' command, TBP's method even works without 'leaving' Leo !

* Disable '@settings' tree in 'myLeoSettings.leo' & restart Leo - OK? - YES.
* Enable '@settings' tree in 'myLeoSettings.leo' & restart Leo a second time - OK? - YES.

Hi Victor

    Where do these 'prompts' come from please? (I am not very familiar with the restart-leo command/feature)

I  am  not sure, if I understand your question correctly. 

Those 'prompts' are just my notes, which I use to document my work / thoughts in Leo outlines since a long time  ...

I don't remember when & how I first found out about the 'restart-leo' command. 

Most likely Edward mentioned it here in the forum ...

With kind regards,

Viktor

Hi Victor - ah, I see. I was misunderstanding your notes as some sort of prompts Leo was putting out (and that I wasn't seeing...)

    Thanks

    Jon