local keystroke commands not working on 6.8.10-devel?

[jkn]

Hi all

    I recently pulled  Leo 6.8.10-devel (build 4faccf02ed), partly to take a look at the 'find history' feature. I have a comment about that, but it will wait...

I am seeing that at least some of my commands, defined in myLeoSettings.py, no longer seem to be having an effect. These are commands which are bound to keystrokes - and the bindings can be seen via 'show-bindings'.

I'm happy to go a bit deeper and report back, but I would have thought others would have shouted if this behaviour was reflected generally? Just wondered if it might be something local to me...

Cheers, Jon N

[jkn]

Hmm, seems to perhaps be due to some different API behaviour? My macros are cursor movement ones, and

    c.editCommands.endOfLine(None)

does not seem to be having the effect it used to?

[Edward K. Ream]

On Mon, Jun 8, 2026 at 4:51 AM jkn <jkn...@nicorp.co.uk> wrote:

Hmm, seems to perhaps be due to some different API behaviour? My macros are cursor movement ones, and

    c.editCommands.endOfLine(None)

Please file a Leo issue for this.

Edward

[jkn]

Hmm - I have just switched back to v6.8.9 and am seeing the same behaviour!

Something weird is going on, I will investigate further before filing an issue

[Thomas Passin]

I have had odd behavior several times recently after pulling an updated version of Leo. Each time the problems were cured by deleting all the *.pyc files in the Leo directory tree.

[Edward K. Ream]

On Mon, Jun 8, 2026 at 7:15 AM Thomas Passin <tbp1...@gmail.com> wrote:

I have had odd behavior several times recently after pulling an updated version of Leo. Each time the problems were cured by deleting all the *.pyc files in the Leo directory tree.

Interesting.

Edward

[Thomas Passin]

It's hard to understand because Python is (or was) supposed to recompile when a source file is more recent than the previously compiled one. 

[Edward K. Ream]

On Monday, June 8, 2026 at 7:15:40 AM UTC-5 tbp1...@gmail.com wrote:

I have had odd behavior several times recently after pulling an updated version of Leo. Each time the problems were cured by deleting all the *.pyc files in the Leo directory tree.

I suggest doing git bisect to determine the first version of Leo that fails. It might be one or two versions back.

Edward

[jkn]

Hi Thomas

    that is a very good point; I have had the same observation myself, from time to time (and thought ...  'that is not supposed to happen').

It would also answer the question about what might be different ... 6.8.9 was working fine for me earlier.

However, I have just tried deleting a.. the .pyc files (before using v6.8.10 again), and the problem still seems to be there.

I now have a trivial command which is supposed to execute c.editCommands.endOfLine(None), it does to cause the cursor to move. I will experiment further.

(FWIW, the other other 'it happens occasionally' problem I have is with abbreviations; sometimes these do not seem to get correctly expanded. The behaviour seems different within different .leo files, if I have more than one open).

This is all a bit hard to report/act on, I appreciate...

Regards, J^n

[jkn]

Mild, puzzling, update:

on a different machine, also previously running v6.8.9 with the same commands successfully ... I switch to 6.8.10-devel, and the custom command fails. I then revert to v6.8.9, remove all the .pyc files to be sure ... and now that also fails (possibly in slightly different ways, it's a bit hard to be sure).

Until I can isolate what is going on here it does not seem useful to raise an issue. But I cannot see where the difference may be. I have not upgraded Python/PyQt recently.

I will try versions of:

    - removing the git cache

    - checking leo out into a new directory

to see if I can better isolate things. But other suggestions welcome!

    Thanks, J^n

[Thomas Passin]

On Tuesday, June 9, 2026 at 7:50:09 AM UTC-4 jkn wrote:

Mild, puzzling, update:

on a different machine, also previously running v6.8.9 with the same commands successfully ... I switch to 6.8.10-devel, and the custom command fails. I then revert to v6.8.9, remove all the .pyc files to be sure ... and now that also fails (possibly in slightly different ways, it's a bit hard to be sure).

Until I can isolate what is going on here it does not seem useful to raise an issue. But I cannot see where the difference may be. I have not upgraded Python/PyQt recently.

I will try versions of:

    - removing the git cache

    - checking leo out into a new directory

to see if I can better isolate things. But other suggestions welcome!

This sounds much like the problems I had. They were resolved after I deleted all the .pyc files as I had said but maybe that wasn't the entire story. In one my cases, I forget the details, I went back through earlier versions until I got one that worked right, then went forward. When one version misbehaved I went back to  check and versions that had worked now didn't.

That's when I thought of deleting .pyc files and the issues went away. This sequence happened twice a few weeks apart.  Maybe there was more to it than just .pyc files. I can't see what, though.

[jkn]

Hi Thomas

    yes ... and the same 'quirky' pattern of things sometimes working, sometimes not, I think applies to my observations about abbreviations. I keep trying to find the time to give proper reports...

[jkn]

Update - actually, for this case at least there does seem to be a specific code change which is causing the problem I am seeing.

Edward has recently added code in leo/commands/editCommands.py. to EditcommandsClass.moveWithinLineHelper():

    def moveWithinLineHelper(self, event: LeoKeyEvent, spot: str, extend: bool) -> None:
        w = event.w if event else None    # git blame shows changes around here ;-)
        if not g.isTextWrapper(w):
            return

But within my command this is getting called with event as None:

        c.editCommands.beginningOfLine(None)   # calls moveWithinLineHelper()
        ....

        c.editCommands.endOfLine(None)         # ditto

I am not sure what else to use for a parameter here?

I will raise an issue on this. 

Thanks, J^n

[jkn]

Issue https://github.com/leo-editor/leo-editor/issues/4735 raised

[Thomas Passin]

event is used like this in moveToHelper:

    w = event.w if event else None
  if not g.isTextWrapper(w):
        return

Because of Python's duck typing, any object that has a w property is going to work. w is supposed to be the wrapper for the editor you are using. For the body editor, this is

body = c.frame.body  # LeoQtBody
wrapper = body.wrapper  # QTextEditWrapper

Or you could create an actual event using c and any values for the other args:

event = LeoKeyEvent(
        c, binding=binding, char=char, w=w, x=x, y=y, x_root=x_root, y_root=y_root
        )

If you create the event this way and do not specify w, it will be computed for you using whatever object has the focus.

[jkn]

[FYI Edward has made some changes in a PR which address this - to be merged]

I can't currently explain my observations above about switching between versions; I will let that lie for now

    J^n