Félix: would Position/Vnode methods in ts be a good idea?

[Edward K. Ream]

Would writing methods like p.moveToNext in typescript help leoInteg in any way?

Would doing so help reduce traffic with leobridgeserver.py?

Edward

[Félix]

Hi Edward,

Good question, as I'm currently re-writing a good part of the updating and refreshing logic since the addition of the 'direct tree browsing' mode.  (ar-jan's great suggestion)

 ...and the ad-hoc addition of the documents panel, and the @ buttons panel - which refresh at every single simple operations 

... (meaning the last 2-3 weeks of features additions now require some refactoring to make everything only refresh when really needed, which i'm working on)

I'm also making sure to remove all unneeded python functions that can be replaced by leoCommand concept you brought forward. 

About your question, the thing is for that specific point you're mentioning : vscode's tree only know about whats visible. so unfolding and going right would require a call anyways. So not that big of an improvements. (The big improvement will be that it wont refresh everything after i'm done with the current issues.)

But the tree-navigation and node moving will also be greatly improved when I implement the 'murmurhash' ids to replace the actual 'incremented number' ids, which for refreshes of every nodes when the tree refreshes. (issue #74)

Félix

p.s. I'm thinking a 'real compiled extension' release is not to far ahead,  maybe still a good 2-3 months of work overall to orchestrate and finish all the remaining issues :) 

[Edward K. Ream]

On Mon, Aug 3, 2020 at 6:12 PM Félix <felix...@gmail.com> wrote:

About your question, the thing is for that specific point you're mentioning : vscode's tree only know about whats visible. so unfolding and going right would require a call anyways. So not that big of an improvements. (The big improvement will be that it wont refresh everything after i'm done with the current issues.)

But the tree-navigation and node moving will also be greatly improved when I implement the 'murmurhash' ids to replace the actual 'incremented number' ids, which for refreshes of every nodes when the tree refreshes. (issue #74)

Thanks for this. It's good to know that porting Leo's core to ts won't be necessary :-)

Edward

[Félix]

although sending the whole tree structure after calls have been resolved (when idle) to remove the need to call the python side when only browsing without changing the structure, would be an improvement in speed (for future improvements after main features are done)

Félix

[Edward K. Ream]

On Wed, Aug 5, 2020 at 3:09 PM Félix <felix...@gmail.com> wrote:

although sending the whole tree structure after calls have been resolved (when idle) to remove the need to call the python side when only browsing without changing the structure, would be an improvement in speed (for future improvements after main features are done)

Good to know.

Edward