Removed @chapter on undo

[vitalije]

Hello,
I have been using Leo 4.8 or 4.9 for a long time (and older versions too). Recently, I updated my Leo to Leo-5.0-final. I am using ubuntu 14.04, Python 2.7.6, PyQt 4.8.6.

In almost any of my leo files I have several @chapter nodes and didn't have any troubles until a few days ago when I realized that (at least one) @chapter disappeared. I thought that maybe I unintentionally pressed delete key. Anyway, I pulled older version of the file and manually copied/cloned nodes to recreate missing @chapter.

Today, I have noticed a message in log window "Note: Removed chapter ...". I pressed Ctrl+Z to undo action, but I was very surprised when another message appeared informing me that the other @chapter was removed too. I looked in "Edit" menu and there was command "Redo Create Chapter" which I executed twice and luckily my @chapters were restored.

I am absolutely sure that I have had those @chapter nodes for some time, i.e. they weren't created today. Yet, Leo's undo command removed my @chapters as if my last action was 'chapter-create'.

I tried to reproduce the problem with the new Leo file, but with no success.

It looks like a serious and dangerous bug to me.
I assume that @chapter commands and @chapter nodes are still supported (am I wrong with that assumption?)

Vitalije

[vitalije]

Yes, certainly there is a bug related to chapter commands.

I haven't reproduced the original bug, but I found possible related bug.
To reproduce it:

1. open a new Leo file.
2. Execute command from menu Cmds -> Chapters -> Chapter-Create.
3. Type in mini-buffer non-ASCII name for newly created chapter for example copy and paste word "Проба" in mini-buffer and press enter.
4. Leo will insert two @chapter nodes and one of them will have the given name, but the other one will have ???? as name.

When selecting non-ASCII named chapters strange things happen. Sometimes Leo creates a new chapter.

HTH

Vitalije.

about my installation:

Leo Log Window
Leo 5.0-final, build 20141124101406, Mon Nov 24 10:14:06 CST 2014
Git repo info: branch = master, commit = 7515bed9d5ad
Python 2.7.6, PyQt version 4.8.6
linux2

[Matt Wilkie]

On Tue, Dec 16, 2014 at 4:20 AM, vitalije <vita...@gmail.com> wrote:

It looks like a serious and dangerous bug to me.

I'd also file a report at https://github.com/leo-editor/leo-editor/issues, to help insure it doesn't get lost in the holiday goings on.

-Matt

[vitalije]

I'd also file a report at https://github.com/leo-editor/leo-editor/issues, to help insure it doesn't get lost in the holiday goings on.

Done.

[Edward K. Ream]

On Fri, Dec 19, 2014 at 1:12 PM, vitalije <vita...@gmail.com> wrote:

When selecting non-ASCII named chapters strange things happen. Sometimes Leo creates a new chapter.

​Thanks for this report.  Please file a bug report at https://github.com/leo-editor/leo-editor/issues.

Edward​

 

[vitalije]

​Thanks for this report.  Please file a bug report at https://github.com/leo-editor/leo-editor/issues.
 

I did.

https://github.com/leo-editor/leo-editor/issues/126