PR #4033 (in devel) creates layouts

45 views
Skip to first unread message

Edward K. Ream

unread,
Aug 28, 2024, 11:22:01 AM8/28/24
to leo-editor
PR #4033 creates six official layouts. Two layouts codify previous de-facto layouts. Four others are the result of recent requests.

See the PR for a thorough description of all its features. The PR does not include everything that Thomas and I have discussed, but it should be a firm foundation for further work.

Edward

Thomas Passin

unread,
Aug 28, 2024, 12:07:39 PM8/28/24
to leo-editor
I have some objections, but for right now I object to VR being forcibly included in all these layouts.  Many times I don't want VR/VR3 at all on startup.  And if I do, I want it to be VR3 unless I'm comparing the two's behavior or rendering. Sometimes I want to change where VR/VR3 appear, and I sure don't want to find the outline's setting tree, edit it (while having to remember the exact name of the layout I want), and reload the outline.

So in my view there is a lot of work to be done on the user interface, at a minimum.

In addition, the VR code has been changed so that an instance cannot be found if its parent has been set to None.  VR3, by means of controllers[h], can. Also there seems to be no way to make VR a singleton per outline, as it used to be and (IMO) should be.

Edward K. Ream

unread,
Aug 28, 2024, 12:20:21 PM8/28/24
to leo-e...@googlegroups.com
On Wed, Aug 28, 2024 at 11:07 AM Thomas Passin <tbp1...@gmail.com> wrote:

I have some objections, but for right now I object to VR being forcibly included in all these layouts. 

Layouts add VR or VR3 only if the user enables the corresponding plugin.

Many times I don't want VR/VR3 at all on startup.  And if I do, I want it to be VR3 unless I'm comparing the two's behavior or rendering. Sometimes I want to change where VR/VR3 appear, and I sure don't want to find the outline's setting tree, edit it (while having to remember the exact name of the layout I want), and reload the outline.

There are two ways to switch layouts easily. 

Method 1

   <Alt-X> use-<tab>

shows a list of commands that switch layouts.

Method 2

An @button/@command node containing the following will change to the "xxx" layout.

    c.doCommandByName('use-xxx-layout')

Edward

Thomas Passin

unread,
Aug 28, 2024, 1:04:58 PM8/28/24
to leo-editor
"Layouts add VR or VR3 only if the user enables the corresponding plugin"

I always enable them but I don't always want them on display when I open a given outline.

Jacob Peck

unread,
Aug 28, 2024, 1:29:42 PM8/28/24
to leo-e...@googlegroups.com
Agreed, I typically want vr hidden unless I explicitly summon it.

Jake

On Aug 28, 2024, at 1:05 PM, Thomas Passin <tbp1...@gmail.com> wrote:


--
You received this message because you are subscribed to the Google Groups "leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email to leo-editor+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/04bdd823-92bc-41ae-8b8b-384f4634c4ben%40googlegroups.com.

Thomas Passin

unread,
Aug 28, 2024, 1:41:03 PM8/28/24
to leo-editor
Trying one of the "use-" commands using the newest devel revision (I fetched it just now) does nothing but return this message:

Please create an `@string qt-layout-name` node.



Edward K. Ream

unread,
Aug 29, 2024, 7:01:36 AM8/29/24
to leo-e...@googlegroups.com
On Wed, Aug 28, 2024 at 12:05 PM Thomas Passin <tbp1...@gmail.com> wrote:
"Layouts add VR or VR3 only if the user enables the corresponding plugin"

I always enable them but I don't always want them on display when I open a given outline.

I'm not sure what your complaint is. The VR/VR3 pane's won't become visible until the user requests them to become visible.

Edward

Thomas Passin

unread,
Aug 29, 2024, 7:29:44 AM8/29/24
to leo-editor
The layout ASCII art (nice job on that, BTW) shows a VR panel so I expected a VR panel to show up. Maybe asterisk the "VR" label to indicate it's conditional.

Edward K. Ream

unread,
Aug 29, 2024, 8:19:37 AM8/29/24
to leo-e...@googlegroups.com
On Thu, Aug 29, 2024 at 6:29 AM Thomas Passin <tbp1...@gmail.com> wrote:
The layout ASCII art (nice job on that, BTW) shows a VR panel so I expected a VR panel to show up. Maybe asterisk the "VR" label to indicate it's conditional.

I see the confusion. The layout diagrams show where the VR/VR3 will appear if they are visible.

Edward
Reply all
Reply to author
Forward
0 new messages