PR #96: assertion fail
8 views
Skip to first unread message
Daniel Nilsson
Apr 1, 2025, 4:44:31 PMApr 1
to LDMud Talk
Hello!
So, I was the one posting the PR today. I had problems with parse_command(). Every time a call to parse_command() crashed the driver for me:
interpret.c:16339: eval_instruction: Assertion `sp[-1].type == T_ARG_FRAME' failed.
It seems parse_command() is not commonly used today, but I'm porting cdlib to ldmud and that lib uses parse_command() here and there.
I found out what was happening and where at work on my lunch break after having pulled my hair the whole weekend about this. So I sent in a patch that made the crash go away for me. I have absolutely no idea what other implications this fix could have for anything else. C is not my expertise and I find the code quite confusing. I'm just happy I could figure this much out.
/Daniel
So, I was the one posting the PR today. I had problems with parse_command(). Every time a call to parse_command() crashed the driver for me:
interpret.c:16339: eval_instruction: Assertion `sp[-1].type == T_ARG_FRAME' failed.
It seems parse_command() is not commonly used today, but I'm porting cdlib to ldmud and that lib uses parse_command() here and there.
I found out what was happening and where at work on my lunch break after having pulled my hair the whole weekend about this. So I sent in a patch that made the crash go away for me. I have absolutely no idea what other implications this fix could have for anything else. C is not my expertise and I find the code quite confusing. I'm just happy I could figure this much out.
/Daniel
Reply all
Reply to author
Forward
0 new messages