It turned out to be fairly easy (except for a detail I'll tak about later).
Christian K has reviewed some of the patches and helped me with some minor
doubts.
The one thing I don't know how to handle it the merge of r251, which introduces
appending of dchars to char[]. This revision add a couple of runtime functions,
and I don't know how to do that in LDC.
The merged patch is working the same as before, though, it only affects code
using a previously unsupported feature, so old code should work fine. Code
trying to use the new feature fails with an assertion (tried with a simple
example), where there was a nice error message before.
Each and every patch was minimally tested, each compiles, can compile the
runtime and a simple hello world application using a precompiled tango (it uses
only the tango.io.Console module). Tango user library was *not* compiled in
each revision, just the runtime.
I hope somebody can give me some directions on how to improve patch 04 (merge
of r251) before mergind this into LDC though.
I'm sorry I've used git for this patches, I'm much more comfortable with it,
but I guess I can "convert" it back to hg if you want to merge them.
Thanks.
Thanks for doing this! Let's discuss integrating the patches IRC.
Christian
OK, I thought the ML was a better place for discussing the patches, but
I guess you prefer the IRC channel based on the low traffic on the list :)
I prefer the ML because it gets indexed and it's not "volatile", in IRC is
more likely that people that isn't logged in right now (or even sitting at
the PC right now) won't see the patches at all.
But I can understand if you are used to discussing this stuff in the IRC
channel, we can do it there too.
--
Leandro Lucarella (AKA luca) http://llucax.com.ar/
----------------------------------------------------------------------
GPG Key: 5F5A8D05 (F8CD F9A7 BF00 5431 4145 104C 949E BFB6 5F5A 8D05)
----------------------------------------------------------------------
Si pensas que el alma no se ve
El alma sí se ve y puede combinar muy bien