My patch for issue 135

[Kunshan Wang]

This is my attempt to fix issue 135.

This patch modifies MMapArea.py in the src directory.

*** MMapArea.py.old 2009-02-26 10:51:58.000000000 +0800
--- MMapArea.py 2009-02-26 10:54:08.000000000 +0800
***************
*** 797,803 ****
height = area.height / self.scale_fac
for t in self.thoughts:
try:
! if t.lr[0] >= ax and t.ul[0] <= ax + width and t.lr[1] <= ay +
height and t.ul[1] >= ay:
t.draw (context)
except:
t.draw(context)
--- 797,803 ----
height = area.height / self.scale_fac
for t in self.thoughts:
try:
! if t.lr[0] >= ax and t.ul[0] <= ax + width and t.lr[1] >= ay and
t.ul[1] <= ay + height:
t.draw (context)
except:
t.draw(context)

[Martin Schaaf]

On Wed, 25 Feb 2009 19:18:33 -0800 (PST)
Kunshan Wang wrote:

>
> This is my attempt to fix issue 135.

Thanks for the patch but it doesn't fix the problem on my system.
Instead I checked in the patch from wks1986 from the issue itself.

Thanks for your help.

Bye,
martin.

[Kunshan Wang]

Can you show me what was wrong?

The patch here is identical to that in the issue itself. Is it the
problem about the format of the diff file?

Kunshan Wang
2009-02-27 10:08:42+08:00

>  signature.asc
> < 1KViewDownload

[Matthias Vogelgesang]

Hello,

On Fri, Feb 27, 2009 at 03:09, Kunshan Wang <wks...@gmail.com> wrote:
>
> Can you show me what was wrong?
>
> The patch here is identical to that in the issue itself.  Is it the
> problem about the format of the diff file?

I would say, you should use the unified diff format. Otherwise, thanks
for all your help.

P.S.: Next week, I've finished an exam and can do some more work on
labyrinth again.

--
Matthias Vogelgesang
Public-Key: http://tinyurl.com/2qcydl

[Martin Schaaf]

On Thu, 26 Feb 2009 18:09:43 -0800 (PST)
Kunshan Wang wrote:

>
> Can you show me what was wrong?

All boxes disappeared and only the connections appear.

> The patch here is identical to that in the issue itself. Is it the
> problem about the format of the diff file?

No. Look at what I checked in.

[Wang Kunshan]

By the way, you checked in my typo. It shouldn't be height0. You
should have seen all boxes drawn by the try-except: statement which
catches the NameError exception.

Both algorithm is based on the fact that ul[0]<=lr[0] and
ul[1]<=lr[1]. If it is not always this case, neither algorithm would
work.

2009/2/28 Martin Schaaf <mas...@ma-scha.de>: