[freebsd/kyua] 6d11f2: Don't pass NULL to unique_ptr constructors

0 views
Skip to first unread message

John Baldwin

unread,
Apr 30, 2025, 12:58:22 PMApr 30
to kyua...@googlegroups.com
Branch: refs/heads/NULL_cleanups
Home: https://github.com/freebsd/kyua
Commit: 6d11f278301afea28af4df6554e8ce346cf40a38
https://github.com/freebsd/kyua/commit/6d11f278301afea28af4df6554e8ce346cf40a38
Author: John Baldwin <j...@FreeBSD.org>
Date: 2025-04-30 (Wed, 30 Apr 2025)

Changed paths:
M utils/process/child.cpp

Log Message:
-----------
Don't pass NULL to unique_ptr constructors

This is ambiguous when NULL is defined to an integral constant.
Instead, use the more iodiomatic pattern of {} to construct a default
pointer.

Fixes: e5449aa (Switch from std::auto_ptr<> to std::unique_ptr<>, 2025-04-11)


Commit: 823ad6a3bd8ce53b5f9b79f8f385740b5ca2200a
https://github.com/freebsd/kyua/commit/823ad6a3bd8ce53b5f9b79f8f385740b5ca2200a
Author: John Baldwin <j...@FreeBSD.org>
Date: 2025-04-30 (Wed, 30 Apr 2025)

Changed paths:
M utils/fs/directory.cpp
M utils/logging/operations.cpp
M utils/process/child.cpp
M utils/process/executor.cpp
M utils/signals/interrupts.cpp
M utils/signals/timer.cpp

Log Message:
-----------
Don't pass NULL to std::unique_ptr<>::reset()

No functional change, this is simply more idiomatic.


Compare: https://github.com/freebsd/kyua/compare/6d11f278301a%5E...823ad6a3bd8c

To unsubscribe from these emails, change your notification settings at https://github.com/freebsd/kyua/settings/notifications

Enji Cooper

unread,
May 2, 2025, 3:04:43 PMMay 2
to kyua...@googlegroups.com
Branch: refs/heads/master
Commit: 86fd66c95d1a2422ae330f49e8ba13e4270e094e
https://github.com/freebsd/kyua/commit/86fd66c95d1a2422ae330f49e8ba13e4270e094e
Author: Enji Cooper <ng...@FreeBSD.org>
Date: 2025-05-02 (Fri, 02 May 2025)

Changed paths:
M utils/fs/directory.cpp
M utils/logging/operations.cpp
M utils/process/child.cpp
M utils/process/executor.cpp
M utils/signals/interrupts.cpp
M utils/signals/timer.cpp

Log Message:
-----------
Merge pull request #265 from freebsd/NULL_cleanups

Null cleanups


Compare: https://github.com/freebsd/kyua/compare/126e6be38a76...86fd66c95d1a
Reply all
Reply to author
Forward
0 new messages