Still Failing: ngie-eign/kyua#102 (add-googletest-support - fa43d07)

0 views
Skip to first unread message

Travis CI

unread,
May 20, 2019, 12:49:21 AM5/20/19
to kyua...@googlegroups.com

ngie-eign

/

kyua

branch iconadd-googletest-support

arrow to build time
clock icon5 mins and 14 secs

Enji Cooper avatarEnji Cooper

Address some of @jmmv's comments in #203

This change does the following things:

* Leverages utils/cmdline/*, instead of reinventing the wheel.
* Consolidates googletest_results tests/setting for clarity.
* Eliminates an unnecessary variable/comments.
* Removes some duplicative TODOs/fixes TODO comment formatting.
* Inlines temporary variables where possible/sensible.
* Moves global variables into the anonymous global namespace.
* Localizes the variable initialization near its use.
* Adds more helpful comments above potentially obfuscated code.
* Use list/set initialization instead of using the equivalent unrolled
version with `.insert()`/`.push_back()`.
* Fix indentation.

Signed-off-by: Enji Cooper <yaneu...@gmail.com>

Want to know about upcoming build environment updates?

Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you!

SIGN UP HERE
book icon

Documentation about Travis CI

Have any questions? We're here to help.
Unsubscribe from build emails from the ngie-eign/kyua repository.
To unsubscribe from all build emails, please update your settings.
black and white travis ci logo

Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy Jacops | Contact: con...@travis-ci.com | Amtsgericht Charlottenburg, Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß §27 a Umsatzsteuergesetz: DE282002648

Reply all
Reply to author
Forward
0 new messages