[freebsd/kyua] 16ab76: Fix running `executor_pid_test` on ZFS
0 views
Skip to first unread message
Enji Cooper
Nov 30, 2024, 8:30:02 PM11/30/24
to kyua...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/freebsd/kyua
Commit: 16ab76482a88ab70fe46294fd2120dd56d033982
https://github.com/freebsd/kyua/commit/16ab76482a88ab70fe46294fd2120dd56d033982
Author: Enji Cooper <ng...@FreeBSD.org>
Date: 2024-11-30 (Sat, 30 Nov 2024)
Changed paths:
M utils/process/Kyuafile
M utils/process/Makefile.am.inc
A utils/process/executor_pid_test.c
R utils/process/executor_pid_test.cpp
Log Message:
-----------
Fix running `executor_pid_test` on ZFS
The testcases prior to this change relied on setting UF_NOUNLINK, which
is unfortunately bugged on ZFS: ZFS does not treat UF_NOUNLINK as a valid
value for fflags, which causes the testcases to fail.
Switch to SF_NOUNLINK. This particular fflag works work ZFS, unlike
UF_NOUNLINK, but requires root privileges, so add the needed metadata
to the Kyuafile.
As part of this, I needed to convert the test from atf-c++(3) to
atf-c(3). The atf-c++(3) APIs do not have the printf-like equivalent
formatting, so it was very difficult figuring out why things weren't
working in atf-c++(3).
While here, clean up the code to DRY some of the repeated logic that it
contained.
The UF_NOUNLINK bug has been reported in https://github.com/openzfs/zfs/issues/16809 .
Fixes: e26c8047f7299f046f87308705b062973d686f5f
Commit: 66827515b0e599e2b96fc459740ddf2f792c9739
https://github.com/freebsd/kyua/commit/66827515b0e599e2b96fc459740ddf2f792c9739
Author: Enji Cooper <ng...@FreeBSD.org>
Date: 2024-11-30 (Sat, 30 Nov 2024)
Changed paths:
M utils/process/Kyuafile
M utils/process/Makefile.am.inc
A utils/process/executor_pid_test.c
R utils/process/executor_pid_test.cpp
Log Message:
-----------
Merge pull request #234 from ngie-eign/fix-executor-pid-test-on-zfs
Fix running `executor_pid_test` on ZFS
Compare: https://github.com/freebsd/kyua/compare/d0a1ffa7a178...66827515b0e5
To unsubscribe from these emails, change your notification settings at https://github.com/freebsd/kyua/settings/notifications
Home: https://github.com/freebsd/kyua
Commit: 16ab76482a88ab70fe46294fd2120dd56d033982
https://github.com/freebsd/kyua/commit/16ab76482a88ab70fe46294fd2120dd56d033982
Author: Enji Cooper <ng...@FreeBSD.org>
Date: 2024-11-30 (Sat, 30 Nov 2024)
Changed paths:
M utils/process/Kyuafile
M utils/process/Makefile.am.inc
A utils/process/executor_pid_test.c
R utils/process/executor_pid_test.cpp
Log Message:
-----------
Fix running `executor_pid_test` on ZFS
The testcases prior to this change relied on setting UF_NOUNLINK, which
is unfortunately bugged on ZFS: ZFS does not treat UF_NOUNLINK as a valid
value for fflags, which causes the testcases to fail.
Switch to SF_NOUNLINK. This particular fflag works work ZFS, unlike
UF_NOUNLINK, but requires root privileges, so add the needed metadata
to the Kyuafile.
As part of this, I needed to convert the test from atf-c++(3) to
atf-c(3). The atf-c++(3) APIs do not have the printf-like equivalent
formatting, so it was very difficult figuring out why things weren't
working in atf-c++(3).
While here, clean up the code to DRY some of the repeated logic that it
contained.
The UF_NOUNLINK bug has been reported in https://github.com/openzfs/zfs/issues/16809 .
Fixes: e26c8047f7299f046f87308705b062973d686f5f
Commit: 66827515b0e599e2b96fc459740ddf2f792c9739
https://github.com/freebsd/kyua/commit/66827515b0e599e2b96fc459740ddf2f792c9739
Author: Enji Cooper <ng...@FreeBSD.org>
Date: 2024-11-30 (Sat, 30 Nov 2024)
Changed paths:
M utils/process/Kyuafile
M utils/process/Makefile.am.inc
A utils/process/executor_pid_test.c
R utils/process/executor_pid_test.cpp
Log Message:
-----------
Merge pull request #234 from ngie-eign/fix-executor-pid-test-on-zfs
Fix running `executor_pid_test` on ZFS
Compare: https://github.com/freebsd/kyua/compare/d0a1ffa7a178...66827515b0e5
To unsubscribe from these emails, change your notification settings at https://github.com/freebsd/kyua/settings/notifications
Reply all
Reply to author
Forward
0 new messages