Kurento support rtmp

[richmonkey]

Change RecordEndpoint(kmsavmuxer)  mux:flvmux sink:rtmpsink to support  rtmp stream from webrtcendpoint.

Is is Possible?

[Micael Gallego]

We don't know.

You can try it and if it work, you can contribute it with a PR.

Regards

On Thu, Sep 10, 2020 at 5:25 PM richmonkey <houxu...@gmail.com> wrote:

Change RecordEndpoint(kmsavmuxer)  mux:flvmux sink:rtmpsink to support  rtmp stream from webrtcendpoint.

Is is Possible?

--
You received this message because you are subscribed to the Google Groups "kurento" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kurento+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/5690f991-5164-418a-ade0-a14964410b9cn%40googlegroups.com.

[richmonkey]

It works perfect.

 It needs two patch. 

core.patch -> kms-core
elements.patch -> kms-elements

Do I need contribute the patch from github?

[Micael Gallego]

Thank you richmonkey, 

We will take a look at it. 

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/25e5a3e5-1eb4-40bc-991c-bb7012bc48b9n%40googlegroups.com.

[Micael Gallego]

Can you describe what is the supposed behaviour of the patch?

Have you added the capability to record FLV files on disk or it is possible to send the media to a RTMP server?

Can you provide an example of pipeline configuration in Java or JavaScript? 

Regards

[richmonkey]

Yes, Flv and rtmp all tested.

1. test flv:

//here,  I tested with MediaProfileSpecType.MP4, because i do not build the new javaclient sdk.

MediaProfileSpecType profile = MediaProfileSpecType.FLV;

String filePath = "file:///tmp/test.flv";
RecorderEndpoint recorder = new RecorderEndpoint.Builder(pipeline, filePath)
.withMediaProfile(profile).build();

//build webrtcendpoint 

WebRtcEndpoint webrtcEndpoint = ...;

webrtcEndpoint.connect(recorder);

2. test  rtmp,  rtmp server installed  in localhost. 

(gst_element_make_from_uri is compatible with rtmp&file protocol)

just change filePath, other same as flv file.

String filePath = "rtmp://127.0.0.1/live/teststream";

[richmonkey]

Any recorder example can test the patch.

 just change the profile&filePath parameter when build the RecorderEndpoint

profile = flv

filePath = "rtmp://" or "file://xxxx.flv"

在2020年9月14日星期一 UTC+8 下午11:54:37<OpenVidu> 写道：

[richmonkey]

By the patch , i can transfer webrtc stream to rtmp stream(other rtmp server),  it is more power & robus than rtpendpoint -> ffmpeg -> rtmp server

[richmonkey]

I test the patch with rtmp server:

https://github.com/ossrs/srs

It's very simple&powerful

在2020年9月14日星期一 UTC+8 下午11:54:37<OpenVidu> 写道：

[richmonkey]

any new message? Is the patch accepted?

[Juan Navarro]

I've added a new issue to track merging of this patch, so it doesn't get lost in this forum:
https://github.com/Kurento/bugtracker/issues/541

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/25e5a3e5-1eb4-40bc-991c-bb7012bc48b9n%40googlegroups.com.

[Alejandro Sellero Rodríguez]

hi richmonkey,

I was interested in trying out your patch and applied it in a custom build. Sadly it seems not to work in my case. Could be that the patch does not work with the last version of kms (6.15.0)?

Here is the recorder endpoint creation (scala code):
```
val RECORDER_FILE_PATH =
"file:///out/test.flv"
val mediaProfile = MediaProfileSpecType.FLV
val recorder =
new RecorderEndpoint.Builder(mediaPipeline, RECORDER_FILE_PATH).withMediaProfile(mediaProfile).build();
```

And this is the output
```
vs-kurento-media-server_1  | 0:28:04.994304451     1 0x7fc35004a090 WARN                    glib GLib-GObject:0:: value "((KmsRecordingProfile) 11)" of type 'KmsRecordingProfile' is invalid or out of range for property 'profile' of type 'KmsRecordingProfile'
vs-kurento-media-server_1  | 0:28:04.994323174     1 0x7fc35004a090 INFO    KurentoRecorderEndpointImpl RecorderEndpointImpl.cpp:150:RecorderEndpointImpl: Set FLV profile
vs-kurento-media-server_1  | 0:28:05.082859583     1 0x55cab4471900 ERROR                   glib (NULL):0:: kms_base_media_muxer_set_state: assertion 'KMS_IS_BASE_MEDIA_MUXER (obj)' failed
```

[richmonkey]

I think, The key error is " 'KmsRecordingProfile' is invalid or out of range for property 'profile' of type 'KmsRecordingProfile'"

I do't update java sdk, so I have not tested  the new enum KMS_RECORDING_PROFILE_FLV.

The problem is how to add a new profile enum value.

the key function is tested, and the i can get flv file & rtmp stream.

[richmonkey]

Does the kms loaded the new kms-core plugin? maybe the kms still load the old(system path) plugin.

在2020年11月22日星期日 UTC+8 下午11:29:52<alex...@gmail.com> 写道：

[Alejandro Sellero Rodríguez]

Theoretically I installed the custom kms-core as well, I will try to check if the custom build is the loaded one in the next days.

Thanks

[Juan Navarro]

To modify kms-elements, like with any other Kurento module, there are 2 sides of the same coin:

1) Modify the module's implementation in the server, including the generic module definition file(s) (files with ".kmd" extension).
2) Update the client SDK (Java or Javascript) (which gets auto-generated from the .kmd files, by the kurento-module-creator tool).

Here is an example of adding a new format to the RecorderEndpoint: https://github.com/Kurento/kms-elements/pull/13

--
Juan Navarro
Kurento developer
@j1elo at GitHub & Twitter

[Alejandro Sellero Rodríguez]

This PR fits perfectly with what richmonkey did, so the problem has to be in my custom build. I will try to build everything again and see...

Thanks a lot both of you for your answers :)

[Juan Navarro]

You're welcome!

A bit more info, in case it is useful (docs are extense so important info might slip through a quick read), about step (2): auto-generating the client SDK code can be done as explained in Writing Modules or in the Dev Guide.

Regards

--
You received this message because you are subscribed to the Google Groups "kurento" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kurento+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/e80da42e-d39c-4682-9a34-a3b64bff7457n%40googlegroups.com.

[Alejandro Sellero Rodríguez]

Hello again guys,

you were right, the kms-core version I got installed was not the right one. Now I can confirm that I got it to work saving to local and also streaming to Amazon IVS.

If you would like to test it without having to build kurento again I have both modules in this repo in bintray:
https://bintray.com/alex1712/deb/vs-kms-core/6.15.1

https://bintray.com/alex1712/deb/vs-kms-elements/6.15.1

Also you can find the java sdk under this repository:
https://bintray.com/alex1712/maven/kurento-client/6.15.0-VS

If you'd like I already have the changes richmonkey did in a fork in github so I could create a PR and link it in the issue you created (https://github.com/Kurento/bugtracker/issues/541).

[Micael Gallego]

Good news Alejandro!!

If you create a PR it is easier for us to apply it to the code base and include it with the new release.

Regards

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/8a1ba1cf-169c-4cac-9b83-b3a21010e914n%40googlegroups.com.

[richmonkey]

great, waiting the new release.

[Alejandro Sellero Rodríguez]

Hi, I was creating the PR and I notice that 1 of the conditions is to add tests for the new features, in my case I just took the patches and applied them, I am not really a C developer and would be really hard for me to write the tests.

So, I will leave you here a link to the draft PR's with the changes:
https://github.com/Kurento/kms-core/pull/24
https://github.com/Kurento/kms-elements/pull/30

Sorry, I hope that helps anyway :)

[Micael Gallego]

No problem, thanks! 

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/912141d6-c542-4652-9e78-26d04c42531dn%40googlegroups.com.

[Juan Navarro]

Hi,

I see in the Pull Request that the profile is only available for audio+video. So, here is my question: does it make sense to provide it also for video-only and/or audio-only?

Are there use cases that would benefit for an audio-only FLV recording?

--
Juan Navarro
Kurento developer
@j1elo at GitHub & Twitter

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/CAFXW_DuXij-G4JuR0doFa%2BOssGKYj7JcK%3DkPxAJVNsS5EBjqug%40mail.gmail.com.

[Alejandro Sellero Rodríguez]

I am really new to media software and C in general, I think richmonkey could answer better than me :)

[richmonkey]

And  flv is not better than mp4, support flv,  just for rtmp, so i think no audio-only flv is fine.

[Trevor Chan]

Hi everyone,

How do you configure the RecorderEndpoint filepath to use an rtmps location with a stream key? I'm also trying to build kurento with these modules to stream to Amazon IVS  but can't figure out the configuration. 

Thanks in advance!

[Alejandro Sellero Rodríguez]

Well in my test I just set the MediaProfile to flv and created the RecorderEndpoint with the endpoint from amazon IVS

val mediaProfile = MediaProfileSpecType.FLV
val recorderEndPoint = new RecorderEndpoint.Builder(mediaPipeline, {{AMAZON_ENDPOINT}}.withMediaProfile(mediaProfile).build()

for me, using only this with the custom kurento packages worked

[Trevor Chan]

Hey Alex,

Apologies for the noob question but how did you construct the AMAZON_ENDPOINT? For example, if I have the following IVS credentials:

ingest server:  rtmps://xxxxx.global-contribute.live-video.net:443/app/

stream key:   sk_us-east-1_xxxxx

How do I create the endpoint?

[Alex]

I think to remember that it was just concatenating them:

rtmp://...live-video.net:443/app/{{KEY}}

sorry I don't have the code anymore, I just needed to be check if it works

You received this message because you are subscribed to a topic in the Google Groups "kurento" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/kurento/_1jO6ugsAO4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to kurento+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/6c141d32-b3ae-4d62-99be-cd57c2c58e59n%40googlegroups.com.

--

Alejandro Sellero
alex...@gmail.com

[Trevor Chan]

Sounds good. I'll give that a try. Thanks!

[Neil Young]

Found this thread yesterday and applied the PRs to my KMS source installation on an ARM VM (Apple Silicon). Works like a champ. Took the "official" JS recorder sample and just changed ".webm" to ".flv". Having an FLV now and need to figure out, what to do with it (hints welcome). Having to stream RTMP to somewhere.

These PRs deserve a merge.

Regards

[Juan Navarro]

They were, indeed :-)

https://doc-kurento.readthedocs.io/en/latest/project/relnotes/v6_18_0.html#flv-recording-profile-for-rtmp

--
Juan Navarro
Kurento developer
@j1elo at GitHub & Twitter

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/c8fcf213-6197-4804-9676-26452e073b85n%40googlegroups.com.

[Alejandro Sellero Rodríguez]

Thanks to @richmonkey for the patch :) and thank you for merging it. Looking forward for the release.

[Juan Navarro]

This got merged for the upcoming release of Kurento 6.18, of which a pre-release build is already available in the development nightly builds channel

--
Juan Navarro
Kurento developer
@j1elo at GitHub & Twitter

No problem, thanks! 

--

To view this discussion on the web visit https://groups.google.com/d/msgid/kurento/8a0b559f-9745-4a0d-8ed3-4132ad183524n%40googlegroups.com.