[PATCH] kunit: Extend kconfig help text for KUNIT_UML_PCI

0 views
Skip to first unread message

Thomas Weißschuh

unread,
Sep 16, 2025, 2:16:02 AM (9 days ago) Sep 16
to Brendan Higgins, David Gow, Rae Moar, Shuah Khan, Johannes Berg, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-...@vger.kernel.org, Thomas Weißschuh
Checkpatch.pl expects at least 4 lines of help text.

Extend the help text to make checkpatch.pl happy.

Fixes: 031cdd3bc3f3 ("kunit: Enable PCI on UML without triggering WARN()")
Suggested-by: Shuah Khan <sk...@linuxfoundation.org>
Link: https://lore.kernel.org/lkml/3dc95227-2be9-48a0...@linuxfoundation.org/
Signed-off-by: Thomas Weißschuh <thomas.w...@linutronix.de>
---
Feel free to fold this into the original commit.
---
lib/kunit/Kconfig | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig
index 1823539e96da30e165fa8d395ccbd3f6754c836e..7a6af361d2fc6276b9667be8c694b0c80e33c1e8 100644
--- a/lib/kunit/Kconfig
+++ b/lib/kunit/Kconfig
@@ -112,5 +112,9 @@ config KUNIT_UML_PCI
select UML_PCI
help
Enables the PCI subsystem on UML for use by KUnit tests.
+ Some KUnit tests require the PCI core which is not enabled by
+ default on UML.
+
+ If unsure, say N.

endif # KUNIT

---
base-commit: f20e264262f1e6a6e5302249e37da355d844b52b
change-id: 20250916-kunit-pci-kconfig-357264bb45f4

Best regards,
--
Thomas Weißschuh <thomas.w...@linutronix.de>

David Gow

unread,
Sep 16, 2025, 4:00:51 AM (9 days ago) Sep 16
to Thomas Weißschuh, Brendan Higgins, Rae Moar, Shuah Khan, Johannes Berg, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-...@vger.kernel.org
On Tue, 16 Sept 2025 at 14:16, Thomas Weißschuh
<thomas.w...@linutronix.de> wrote:
>
> Checkpatch.pl expects at least 4 lines of help text.
>
> Extend the help text to make checkpatch.pl happy.
>
> Fixes: 031cdd3bc3f3 ("kunit: Enable PCI on UML without triggering WARN()")
> Suggested-by: Shuah Khan <sk...@linuxfoundation.org>
> Link: https://lore.kernel.org/lkml/3dc95227-2be9-48a0...@linuxfoundation.org/
> Signed-off-by: Thomas Weißschuh <thomas.w...@linutronix.de>
> ---

Reviewed-by: David Gow <davi...@google.com>

Thanks,
-- David
Reply all
Reply to author
Forward
0 new messages