[PATCH net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests

1 view
Skip to first unread message

Karl Mehltretter

unread,
Sep 17, 2026, 2:47:46 AMSep 17
to Steen Hegelund, Daniel Machon, UNGLinu...@microchip.com, Karl Mehltretter, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-ar...@lists.infradead.org, net...@vger.kernel.org, Geert Uytterhoeven, Brendan Higgins, David Gow, Rae Moar, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-...@vger.kernel.org
VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
leaves it disabled. Remove the selection, following the dependency rule
in Documentation/dev-tools/kunit/style.rst.

The debugfs implementation and its tests are already built only with
DEBUG_FS. The other VCAP tests can run without it.

Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehlt...@gmail.com>
---
Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
configurations. The debugfs suite is present only with DEBUG_FS=y and
all four cases pass.

drivers/net/ethernet/microchip/vcap/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/microchip/vcap/Kconfig b/drivers/net/ethernet/microchip/vcap/Kconfig
index 97f43fd4473f..1af30a358a15 100644
--- a/drivers/net/ethernet/microchip/vcap/Kconfig
+++ b/drivers/net/ethernet/microchip/vcap/Kconfig
@@ -40,7 +40,6 @@ config VCAP_KUNIT_TEST
bool "KUnit test for VCAP library" if !KUNIT_ALL_TESTS
depends on KUNIT
depends on KUNIT=y && VCAP=y && y
- select DEBUG_FS
default KUNIT_ALL_TESTS
help
This builds unit tests for the VCAP library.

base-commit: c9151088f1674fd29ff26a20f5fc687acf53a2f0

Daniel Machon

unread,
Sep 18, 2026, 2:50:43 AMSep 18
to Karl Mehltretter, Steen Hegelund, UNGLinu...@microchip.com, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-ar...@lists.infradead.org, net...@vger.kernel.org, Geert Uytterhoeven, Brendan Higgins, David Gow, Rae Moar, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-...@vger.kernel.org
Reviewed-by: Daniel Machon <daniel...@microchip.com>

David Gow

unread,
Sep 21, 2026, 3:56:59 AM (13 days ago) Sep 21
to Karl Mehltretter, Steen Hegelund, Daniel Machon, UNGLinu...@microchip.com, Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-ar...@lists.infradead.org, net...@vger.kernel.org, Geert Uytterhoeven, Brendan Higgins, Rae Moar, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-...@vger.kernel.org
Le 17/09/2026 à 14:47, Karl Mehltretter a écrit :
> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
>
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
>
> Fixes: 552b7d131aa0 ("net: microchip: sparx5: Add VCAP debugfs KUNIT test")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehlt...@gmail.com>
> ---
> Validation on net c9151088f167: x86_64 LLVM builds and QEMU runs
> with DEBUG_FS disabled and enabled. The other VCAP suites pass in both
> configurations. The debugfs suite is present only with DEBUG_FS=y and
> all four cases pass.
>

Acked-by: David Gow <da...@davidgow.net>

Cheers,
-- David


patchwork-b...@kernel.org

unread,
Sep 21, 2026, 6:36:58 PM (12 days ago) Sep 21
to Karl Mehltretter, Steen.H...@microchip.com, daniel...@microchip.com, UNGLinu...@microchip.com, andrew...@lunn.ch, da...@davemloft.net, edum...@google.com, ku...@kernel.org, pab...@redhat.com, linux-ar...@lists.infradead.org, net...@vger.kernel.org, ge...@linux-m68k.org, brendan...@linux.dev, da...@davidgow.net, raem...@gmail.com, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-...@vger.kernel.org
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <ku...@kernel.org>:

On Thu, 17 Sep 2026 08:47:36 +0200 you wrote:
> VCAP_KUNIT_TEST enables DEBUG_FS even when the kernel configuration
> leaves it disabled. Remove the selection, following the dependency rule
> in Documentation/dev-tools/kunit/style.rst.
>
> The debugfs implementation and its tests are already built only with
> DEBUG_FS. The other VCAP tests can run without it.
>
> [...]

Here is the summary with links:
- [net] net: microchip: vcap: Stop selecting DEBUG_FS for KUnit tests
https://git.kernel.org/netdev/net-next/c/2fba93180872

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html


Reply all
Reply to author
Forward
0 new messages