Re: [PATCH] rust: use consistent backtick formatting for NULL in docs

[Miguel Ojeda]

On Mon, Dec 1, 2025 at 4:29 AM Alexandre Courbot <acou...@nvidia.com> wrote:
>
> On Mon Dec 1, 2025 at 6:12 AM JST, Peter Novak wrote:
> > Some doc comments use `NULL` while others use plain NULL.
> > This patch makes it consistent by adding backticks everywhere,
> > matching the majority of existing usage.
> >
> > This is my first kernel patch - just getting familiar with
> > the contribution process.
> >
> > Signed-off-by: Peter Novak <seimu...@gmail.com>
>
> This looks like a pretty good first patch! :)
>
> Just make sure to put the meta-comments (the "This is my first kernel
> patch" sentence) below a `---` line so they don't get picked up in the
> git log. See [1] for an example.
>
> With that sentence removed (which I believe will be done when applying
> if no other fixes are required),
>
> Reviewed-by: Alexandre Courbot <acou...@nvidia.com>
>
> I have double-checked with `rg '\/\/\/.*NULL'` from the `rust` directory
> and this indeed appears to address all cases.
>
> [1] https://lore.kernel.org/rust-for-linux/20251124-bounded_fi...@nvidia.com/

Thanks Alexandre for this welcoming review, and Peter for the patch.

I see Cc's were missing, which explains why there weren't more
reactions. OK, added everyone now: clk, debugfs and KUnit.

It would be nice to have Acked-by's for them, but if nobody shouts, I
guess I will eventually apply it...

Thanks!

Cheers,
Miguel

[Danilo Krummrich]

On Sun Jan 18, 2026 at 11:14 PM CET, Miguel Ojeda wrote:
> It would be nice to have Acked-by's for them

Acked-by: Danilo Krummrich <da...@kernel.org>