[PATCH] kunit: Drop unused parameter from kunit_device_register_internal

1 view
Skip to first unread message

Uwe Kleine-König

unread,
Dec 10, 2025, 1:58:55 AM (9 days ago) Dec 10
to Brendan Higgins, David Gow, Rae Moar, linux-k...@vger.kernel.org, kuni...@googlegroups.com
The passed driver isn't used, so just drop this parameter.

Signed-off-by: Uwe Kleine-König <u.klein...@baylibre.com>
---
lib/kunit/device.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/kunit/device.c b/lib/kunit/device.c
index 520c1fccee8a..f201aaacd4cf 100644
--- a/lib/kunit/device.c
+++ b/lib/kunit/device.c
@@ -106,8 +106,7 @@ EXPORT_SYMBOL_GPL(kunit_driver_create);

/* Helper which creates a kunit_device, attaches it to the kunit_bus*/
static struct kunit_device *kunit_device_register_internal(struct kunit *test,
- const char *name,
- const struct device_driver *drv)
+ const char *name)
{
struct kunit_device *kunit_dev;
int err = -ENOMEM;
@@ -150,7 +149,7 @@ struct device *kunit_device_register_with_driver(struct kunit *test,
const char *name,
const struct device_driver *drv)
{
- struct kunit_device *kunit_dev = kunit_device_register_internal(test, name, drv);
+ struct kunit_device *kunit_dev = kunit_device_register_internal(test, name);

if (IS_ERR_OR_NULL(kunit_dev))
return ERR_CAST(kunit_dev);
@@ -172,7 +171,7 @@ struct device *kunit_device_register(struct kunit *test, const char *name)
if (IS_ERR(drv))
return ERR_CAST(drv);

- dev = kunit_device_register_internal(test, name, drv);
+ dev = kunit_device_register_internal(test, name);
if (IS_ERR(dev)) {
kunit_release_action(test, driver_unregister_wrapper, (void *)drv);
return ERR_CAST(dev);

base-commit: 7d0a66e4bb9081d75c82ec4957c50034cb0ea449
--
2.47.3

David Gow

unread,
Dec 10, 2025, 3:34:41 AM (9 days ago) Dec 10
to Uwe Kleine-König, Brendan Higgins, Rae Moar, linux-k...@vger.kernel.org, kuni...@googlegroups.com
On Wed, 10 Dec 2025 at 14:58, Uwe Kleine-König
<u.klein...@baylibre.com> wrote:
>
> The passed driver isn't used, so just drop this parameter.
>
> Signed-off-by: Uwe Kleine-König <u.klein...@baylibre.com>
> ---

Nice catch, thanks!

Reviewed-by: David Gow <davi...@google.com>

Cheers,
-- David
Reply all
Reply to author
Forward
0 new messages