[PATCH] kunit/usercopy: Add missing MODULE_DESCRIPTION()

0 views
Skip to first unread message

Kees Cook

unread,
Jun 19, 2024, 4:27:02 PM (13 days ago) Jun 19
to Shuah Khan, Kees Cook, Jeff Johnson, Brendan Higgins, David Gow, Rae Moar, Gustavo A. R. Silva, Andrew Morton, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-h...@vger.kernel.org, linu...@kvack.org, linux-...@vger.kernel.org
From: Jeff Johnson <quic_j...@quicinc.com>

Fix warning seen with:

$ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o

Signed-off-by: Jeff Johnson <quic_j...@quicinc.com>
Signed-off-by: Kees Cook <ke...@kernel.org>
---
At Jeff's reminder, I've split this out of:
https://lore.kernel.org/all/20240601-md-lib-tes...@quicinc.com/
since the file got renamed.
---
Cc: Shuah Khan <sk...@linuxfoundation.org>
Cc: Jeff Johnson <quic_j...@quicinc.com>
Cc: Brendan Higgins <brendan...@linux.dev>
Cc: David Gow <davi...@google.com>
Cc: Rae Moar <rm...@google.com>
Cc: "Gustavo A. R. Silva" <gusta...@kernel.org>
Cc: Andrew Morton <ak...@linux-foundation.org>
Cc: linux-k...@vger.kernel.org
Cc: kuni...@googlegroups.com
Cc: linux-h...@vger.kernel.org
Cc: linu...@kvack.org
---
lib/usercopy_kunit.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/usercopy_kunit.c b/lib/usercopy_kunit.c
index e819561a540d..77fa00a13df7 100644
--- a/lib/usercopy_kunit.c
+++ b/lib/usercopy_kunit.c
@@ -331,4 +331,5 @@ static struct kunit_suite usercopy_test_suite = {

kunit_test_suites(&usercopy_test_suite);
MODULE_AUTHOR("Kees Cook <ke...@kernel.org>");
+MODULE_DESCRIPTION("Kernel module for testing copy_to/from_user infrastructure");
MODULE_LICENSE("GPL");
--
2.34.1

Rae Moar

unread,
Jun 20, 2024, 5:01:00 PM (12 days ago) Jun 20
to Kees Cook, Shuah Khan, Jeff Johnson, Brendan Higgins, David Gow, Gustavo A. R. Silva, Andrew Morton, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-h...@vger.kernel.org, linu...@kvack.org, linux-...@vger.kernel.org
On Wed, Jun 19, 2024 at 4:27 PM Kees Cook <ke...@kernel.org> wrote:
>
> From: Jeff Johnson <quic_j...@quicinc.com>
>
> Fix warning seen with:
>
> $ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o
>
> Signed-off-by: Jeff Johnson <quic_j...@quicinc.com>
> Signed-off-by: Kees Cook <ke...@kernel.org>

Hi!

This looks good to me.

Reviewed-by: Rae Moar <rm...@google.com>

Thanks!
-Rae

David Gow

unread,
12:09 AM (23 hours ago) 12:09 AM
to Kees Cook, Shuah Khan, Jeff Johnson, Brendan Higgins, Rae Moar, Gustavo A. R. Silva, Andrew Morton, linux-k...@vger.kernel.org, kuni...@googlegroups.com, linux-h...@vger.kernel.org, linu...@kvack.org, linux-...@vger.kernel.org
On Thu, 20 Jun 2024 at 04:27, Kees Cook <ke...@kernel.org> wrote:
>
> From: Jeff Johnson <quic_j...@quicinc.com>
>
> Fix warning seen with:
>
> $ make allmodconfig && make W=1 C=1 lib/usercopy_kunit.ko
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/usercopy_kunit.o
>
> Signed-off-by: Jeff Johnson <quic_j...@quicinc.com>
> Signed-off-by: Kees Cook <ke...@kernel.org>
> ---
> At Jeff's reminder, I've split this out of:
> https://lore.kernel.org/all/20240601-md-lib-tes...@quicinc.com/
> since the file got renamed.
> ---
> Cc: Shuah Khan <sk...@linuxfoundation.org>
> Cc: Jeff Johnson <quic_j...@quicinc.com>
> Cc: Brendan Higgins <brendan...@linux.dev>
> Cc: David Gow <davi...@google.com>
> Cc: Rae Moar <rm...@google.com>
> Cc: "Gustavo A. R. Silva" <gusta...@kernel.org>
> Cc: Andrew Morton <ak...@linux-foundation.org>
> Cc: linux-k...@vger.kernel.org
> Cc: kuni...@googlegroups.com
> Cc: linux-h...@vger.kernel.org
> Cc: linu...@kvack.org
> ---

Reviewed-by: David Gow <davi...@google.com>

Cheers,
-- David
Reply all
Reply to author
Forward
0 new messages