Exception request: VEP 248 - Stall Detection

[Aseef Imran]

Hi everyone,

I would like to request an exception for VEP 248 (Live Migration Stability & Convergence Improvements; i.e. Stall Detector).

Time Requested: 1 week (July 1st)

VEP Issue: https://github.com/kubevirt/enhancements/issues/248

Relevant PRs:

* https://github.com/kubevirt/kubevirt/pull/17544 (lgtm, approved; fighting CI)

* https://github.com/kubevirt/kubevirt/pull/17860 (lgtm, approved; fighting CI)

* https://github.com/kubevirt/kubevirt/pull/17737 (needs review; rebased on top of the first two PRs making it trickier to review before the first two are merged)

Why It's Likely to Merge: If the exception is granted, this PR is likely to merge as the first two PRs, the largest have already been reviewed and are only pending CI. While the third PR has not been reviewed, I will be deferring some non-essential aspects to the next cycle to minimize the diff to only the relatively trivial changes increasing the chances we can converge with in the requested time period (and possibly much earlier).

[Aseef Imran]

Just posted the simplified PR (the one that needs to be reviewed during the exception period): https://github.com/kubevirt/kubevirt/pull/18240

[Itamar Holder]

Hi Aseef.

Your effort was delayed mainly because of some discussions on controversial topics in the VEP design. To be fair, the VEP was merged and then re-discussed because of pushback that emerged. Despite that, you had the patience to let the discussion settle and did your best to compromise. In addition, the last PR should be relatively straightforward to review (at least I hope so).

I support this exception request.

From my POV, we should try to merge this PR by July 1st. I will review it ASAP.

Itamar.

--
You received this message because you are subscribed to the Google Groups "kubevirt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubevirt-dev...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/kubevirt-dev/0f55da7b-b095-4bcb-a80b-0949bacf4d87n%40googlegroups.com.