KubeVirt Community Meeting 2024-09-18

17 views
Skip to first unread message

Andrew Burden

unread,
Sep 20, 2024, 7:11:57 AM9/20/24
to kubevirt-dev

2024-09-18 MINUTES


Recording: https://youtu.be/CX_NToaxDHY 


Attendees: Federico Fossemo,fitandre(THE WONDER CLOUD),Itamar Holder, Alice Frosi, Lee Yarwood,  sgott, brianmcarey, Adi Aloni vladikr,Jan Schintag, dhiller,Barak Mordehai Daniel Sionov, Mark Lavi, aburden


Introductions:  Welcome everyone to the KubeVirt weekly community meeting


Schedule Check-in: https://github.com/kubevirt/sig-release/blob/main/releases/v1.4/schedule.md
Upcoming CfP Check-in: https://github.com/kubevirt/community/wiki/Events

Agenda and Notes:

Open Floor:

https://intel.github.io/intel-device-plugins-for-kubernetes/cmd/gpu_plugin/labels.html

  • [afrosi] AFAIU, intel device plugins aren’t compatible with kubevirt support for device plugins. Vladik Romanovsky Is this correct?

    • I’m not sure, I haven’t look at it.



Pull Requests that need attention: https://github.com/kubevirt/kubevirt/pulls


Mailing list review: https://groups.google.com/g/kubevirt-dev

  • Triage: nothing jumps out



Bug scrub: https://github.com/kubevirt/kubevirt/issues?q=is%3Aopen+is%3Aissue

(/triage {accepted | build-watcher | duplicate | needs-information | not-reproducible | unresolved})


Flaky test fixes: https://github.com/pulls?q=label%3Akind%2Fflake+repo%3Akubevirt%2Fkubevirt 


Zoom chat:
00:09:32 Andrew: https://docs.google.com/document/d/1nE09vQWcCTW-9Ohe9oCldWrE0he-T_YFJ5D1xNzMtg4/edit

00:11:27 xpivarc: Beta is running late, caused by issue in release build

00:11:35 Harshit Gupta: For Open Floor:

I don't have edit access to the doc.

I did want to get your feedback on my PoC to generalize the hypervisor.

https://github.com/harshitgupta1337/kubevirt/pull/3

00:12:06 afrosi: let me put the link in the agenda

00:13:39 Itamar Holder (iholder101): Is the CfP for FOSDEM open?

Can someone share a link? :)

00:13:46 Harshit Gupta: Reacted to "let me put the link ..." with 👍

00:13:59 Andrew: Is it my audio or is alice not speaking?

00:14:02 acardace: is Alice's audio working? I

00:14:08 afrosi: I'm talking alone

00:14:13 Itamar Holder (iholder101): I don't hear anything.

00:14:30 afrosi: sorry I will reconnect

00:15:04 Itamar Holder (iholder101): Thank you :)

00:17:09 vladik: people need to realize that thier reviews are dependent on them reviewing others people code too. my 2c

00:17:37 Adi Aloni: Personally as a newbie I think reviewing someone else's code without being familiar with the "larger picture" of the codebase and general etiquette can be daunting at times.

00:18:06 Felix Matouschek: Reviews on code style can already be quite helpful

00:18:15 Adi Aloni: Reacted to Reviews on code styl... with "👍"

00:18:43 vladik: Replying to "Personally as a ne..."


this can be something very simple, style or just pointing out minor issues.

00:18:59 Itamar Holder (iholder101): Reacted to "this can be someth..." with 👍

00:19:57 Jed: Replying to "Personally as a newb..."


feel free to ask as many questions as possible, no matter how trivial they feel.

00:19:57 vladik: LLM ;) I'm actually trying to make a POC now.

00:20:01 Adi Aloni: Replying to "Personally as a newb..."


 I concur, but I'm unsure whether that alone cuts it (not that I personally mind contributing my opinion whenever).

00:20:10 Itamar Holder (iholder101): Reacted to "feel free to ask a..." with 👍

00:20:35 afrosi: yeah mentorship for review will be good, at least we could get a pool of people interested in doing it

00:21:39 dhiller: maybe we need a session about how to do code reviews?

00:21:54 Mark Lavi: Reacted to "maybe we need a sess..." with 👍🏽

00:22:19 afrosi: Reacted to "maybe we need a sess..." with 👍🏽

00:22:22 dhiller: +1 to what Itamar says

00:22:48 afrosi: if some part of the code are hard, we could also do some learning session here

00:23:00 Harshit Gupta: Reacted to "if some part of the ..." with 👍

00:25:44 rojaeswaran: These Pull requests from our engineer need attention. It’s been there forever. Your help is very much appreciated.

Kubevirt reviewers have approved the first PR but haven’t been merged yet, any additional inputs to push this PR is much appreciated.

     https://github.com/kubevirt/kubevirt/pull/9668

2. The second PR addresses the need for VMI ReplicaSet and why the VMI Pool can’t be a substitute for VMI Replica Set.

      https://github.com/kubevirt/kubevirt/issues/12581

00:28:57 Itamar Holder (iholder101): +1 Daniel

In kubernetes it works pretty good.

00:29:01 lyarwood: something for the SIGS surely?

00:29:42 vladik: the main issue wrt priority is that we don't have porject priorities

00:30:07 vladik: advertised goals that we can correlate PRs to

00:30:44 vladik: I think each sig can add have such a list and publish these priorities

00:31:07 Itamar Holder (iholder101): FWIW we don't have to wait for community meetings in order to triage

00:31:21 lyarwood: Yup +1, I wouldn't do this on the community call

00:34:46 vladik: https://github.com/kubevirt/community/pull/259

00:35:36 xpivarc: Can somebody share the link?

00:35:59 dhiller: Reacted to "Yup +1, I wouldn't d..." with 👍

00:36:01 vladik: @Harshit Gupta will you be also updating the proposal ?

00:37:17 Andrew: https://github.com/harshitgupta1337/kubevirt/pull/3

00:37:58 lyarwood: Nova 2.0

00:38:25 xpivarc: Reacted to "Nova 2.0" with 🥶

00:38:53 vladik: Replying to "Nova 2.0"


all over again 🤦‍♂️

00:42:02 Itamar Holder (iholder101): https://github.com/kubevirt/community/pull/184#issuecomment-1227605036

00:45:46 acardace: 1.2 to have both

00:48:13 vladik: Isn't the native KubeVirt DP working ?

00:48:52 vladik: Reacted to "1.2 to have both" with 👍

00:59:16 Itamar Holder (iholder101): Talking about lack of approvers.... :)

00:59:56 Orel M: Thank you

01:00:45 vladik: :)

01:01:12 vladik: dosu++

01:01:24 xpivarc: I need to drop, see you
Reply all
Reply to author
Forward
0 new messages