Deprecate Cirros in Kubevirt E2E Tests and Replace them with Alpine

[Vamsikrishna Siddu]

Hello Everyone,

Cirros is not supported for s390x. So, we are not able to run the E2E Tests using Cirros for s390x.  So, I am planning to deprecate the use of Cirros in E2E Tests and replace all the Cirros tests with alpine. I have run couple of tests by replacing cirros with alpine. I did not notice any issues.   Before proceeding I want to get the opinion from the community about any consequences for the other architectures (x86 and arm). 

Discussion links:

https://github.com/kubevirt/kubevirt/pull/12516#discussion_r1743657171

Thanks,

Siddu Vamsikrishna,

IBM Bangalore (Research and Development)

[Antonio Cardace]

On Mon, Sep 16, 2024 at 3:03 PM Vamsikrishna Siddu <vamsikrish...@gmail.com> wrote:

Hello Everyone,

Cirros is not supported for s390x. So, we are not able to run the E2E Tests using Cirros for s390x.  So, I am planning to deprecate the use of Cirros in E2E Tests and replace all the Cirros tests with alpine. I have run couple of tests by replacing cirros with alpine. I did not notice any issues.   Before proceeding I want to get the opinion from the community about any consequences for the other architectures (x86 and arm). 

Hi,

I'd just double check the memory requirements of Cirros vs Alpine, if there's no increase in switching everything to Alpine then I don't see any issues with it.

Thanks,

Antonio

Discussion links:

https://github.com/kubevirt/kubevirt/pull/12516#discussion_r1743657171

Thanks,

Siddu Vamsikrishna,

IBM Bangalore (Research and Development)

--
You received this message because you are subscribed to the Google Groups "kubevirt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubevirt-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubevirt-dev/32b8d751-fcc6-4f7d-b9c5-e978e5b05dfbn%40googlegroups.com.

[Alex Kalenyuk]

This sounds like a good idea, my only worry is that some tests are coupled to Cirros.
For example, currently, our alpine image doesn't have acpid - https://wiki.alpinelinux.org/wiki/Configure_action_when_power-button_is_pressed
while cirros does. This is ofc something we should be able to easily fix, so more of a heads up.

To view this discussion on the web visit https://groups.google.com/d/msgid/kubevirt-dev/CAK69NqAD%2BCXA1-xa2_ibBhSRWq_qcbz-n0Z6E04KZvTaX4uCsQ%40mail.gmail.com.

[Vamsikrishna Siddu]

Thanks Alex and Antonio for the valuable feedback.  I will take these points into consideration and work on these. 

Thanks,

Siddu Vamsikrishna,

[Felix Matouschek]

Hi Siddu,


IIUC Cirros was chosen to conserve resources as much as possible. Do
you know if resource usage goes up when using Alpine compared to
Cirros?

In general, I think this is an acceptable approach and it is also a
good opportunity to switch as many tests as possible to guestless VMs
if they don't require a running guest.

Thanks,
Felix

[Alex Kalenyuk]

This sounds like a good idea, my only worry is that some tests are coupled to Cirros.

Another example is the guest console log tests that may be coupled to Cirros:
https://github.com/kubevirt/kubevirt/blob/378d1f35137e8f22930cba9dafa7e1ed193aa59f/tests/guestlog/guestlog.go#L118-L124

switch as many tests as possible to guestless VMs
if they don't require a running guest.

So apparently guestless VMs are not achievable today on s390x (we still don't know if it's a bug or working as designed),
this is being actively discussed:
https://kubernetes.slack.com/archives/C0163DT0R8X/p1726821876935099?thread_ts=1726468656.344359&cid=C0163DT0R8X 

IIUC Cirros was chosen to conserve resources as much as possible. Do
you know if resource usage goes up when using Alpine compared to
Cirros?

I think they require roughly the same amount of resources, so from that perspective we should be okay:
https://github.com/kubevirt/kubevirt/blob/25240a1e0388c60983968e83a214ed019ab6a5f2/tests/libvmifact/factory.go#L72
 

 

To view this discussion on the web visit https://groups.google.com/d/msgid/kubevirt-dev/8183eeb01ac8fc47d1de76fb6ef3c4ffcc29478f.camel%40redhat.com.

[Vamsikrishna Siddu]

Restarting this discussion inorder to get more feedback on this.

Thanks,

Siddu Vamsikrishna