design-proposal process and organisation suggestions

36 views
Skip to first unread message

Lee Yarwood

unread,
Jun 8, 2023, 11:27:55 AM6/8/23
to kubevirt-dev
Hello all,

I wanted to raise a few changes I think would help improve the design
proposal process for new and old contributors in KubeVirt. I'll raise
this in the next community meeting but feedback is welcome here until
then.

1. s/design-proposals/enhancements/g

I personally found it odd that these proposals lived in the community
repo, IMHO moving them to a stand alone enhancements repo and
obviously renaming the overall process would be useful for new
contributors coming from the wider k8s eco-system.

2. Adding enhancement review time and a soft deadline to the start of
a release cycle

With our move to a longer release cycle I would like to see more
emphasis given to these enhancement proposals earlier in the cycle,
both by contributors and reviewers. Adding some kind of
proposal/review window and/or soft deadline could help focus everyone
on getting agreement earlier in the cycle.

Ultimately I think the KubeVirt community will need an event virtual
or otherwise akin to OpenStack's Project Team Gatherings [1] or
Kubernetes Contributor Summit [2] in the near future to help teams
work through proposals etc early in the cycle. Yes the summit is
useful but a few days of presentations is very different to the
aforementioned meetings. Anyway that's for another suggestion thread.

3. Updating the template with suggestions from KEPs

Comparing our current template with the k8s KEP template we appear to
be missing some useful sections like `troubleshooting` etc that might
be worth adding. Additionally a release checklist would be good to add
to our template but as these proposals are optional that might be too
heavy weight for now.

Regards,

Lee

[1] https://openinfra.dev/ptg/
[2] https://www.kubernetes.dev/events/2023/kcseu/

Fabian Deutsch

unread,
Jun 14, 2023, 8:20:34 AM6/14/23
to Lee Yarwood, kubevirt-dev
Lee,

thanks for pushing us forward on this front.

On Thu, Jun 8, 2023 at 5:28 PM Lee Yarwood <lyar...@redhat.com> wrote:
Hello all,

I wanted to raise a few changes I think would help improve the design
proposal process for new and old contributors in KubeVirt. I'll raise
this in the next community meeting but feedback is welcome here until
then.

1. s/design-proposals/enhancements/g

I personally found it odd that these proposals lived in the community
repo, IMHO moving them to a stand alone enhancements repo and
obviously renaming the overall process would be useful for new
contributors coming from the wider k8s eco-system.


+1

Has the existing Design template worked out? Is there something you see needs to be changed on a design structure level?
 
2. Adding enhancement review time and a soft deadline to the start of
a release cycle

With our move to a longer release cycle I would like to see more
emphasis given to these enhancement proposals earlier in the cycle,
both by contributors and reviewers. Adding some kind of
proposal/review window and/or soft deadline could help focus everyone
on getting agreement earlier in the cycle.

Review window sounds good.
Although I am not sure if we need to tie it to the release.
IOW: Have a Design review Window for _a_ release.
Not _necessarily_: Have a Design review window for _this_ release.
 

Ultimately I think the KubeVirt community will need an event virtual
or otherwise akin to OpenStack's Project Team Gatherings [1] or
Kubernetes Contributor Summit [2] in the near future to help teams
work through proposals etc early in the cycle. Yes the summit is
useful but a few days of presentations is very different to the
aforementioned meetings. Anyway that's for another suggestion thread.

3. Updating the template with suggestions from KEPs

Comparing our current template with the k8s KEP template we appear to
be missing some useful sections like `troubleshooting` etc that might
be worth adding. Additionally a release checklist would be good to add
to our template but as these proposals are optional that might be too
heavy weight for now.

10x

- fabian
 
--
You received this message because you are subscribed to the Google Groups "kubevirt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubevirt-dev...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubevirt-dev/CAPkJ9Du2D%2BQLQwB5eFnNcdzmNP2Ys0c%2Bj6p%2BU%3DMezvAw5_A1kQ%40mail.gmail.com.


Lee Yarwood

unread,
Jun 15, 2023, 5:52:38 AM6/15/23
to Fabian Deutsch, kubevirt-dev
On Wed, 14 Jun 2023 at 13:20, Fabian Deutsch <fdeu...@redhat.com> wrote:
>
> Lee,
>
> thanks for pushing us forward on this front.

My pleasure, thanks!

> On Thu, Jun 8, 2023 at 5:28 PM Lee Yarwood <lyar...@redhat.com> wrote:
>>
>> Hello all,
>>
>> I wanted to raise a few changes I think would help improve the design
>> proposal process for new and old contributors in KubeVirt. I'll raise
>> this in the next community meeting but feedback is welcome here until
>> then.
>>
>> 1. s/design-proposals/enhancements/g
>>
>> I personally found it odd that these proposals lived in the community
>> repo, IMHO moving them to a stand alone enhancements repo and
>> obviously renaming the overall process would be useful for new
>> contributors coming from the wider k8s eco-system.
>>
>
> +1
>
> Has the existing Design template worked out? Is there something you see needs to be changed on a design structure level?

See below, I think that's something we could look at after renaming
and moving tbh.

For now I've captured this in an issue against the community repo to
seek more feedback before making any changes.

Suggestion: Rename design-proposals to enhancements and move into
standalone kubevirt/enhancements repo
https://github.com/kubevirt/community/issues/223

>>
>> 2. Adding enhancement review time and a soft deadline to the start of
>> a release cycle
>>
>> With our move to a longer release cycle I would like to see more
>> emphasis given to these enhancement proposals earlier in the cycle,
>> both by contributors and reviewers. Adding some kind of
>> proposal/review window and/or soft deadline could help focus everyone
>> on getting agreement earlier in the cycle.
>
>
> Review window sounds good.
> Although I am not sure if we need to tie it to the release.
> IOW: Have a Design review Window for _a_ release.
> Not _necessarily_: Have a Design review window for _this_ release.

I'm not sure I understand, by linking it to a release cycle you ensure
it happens early enough for the proposals to turn into code and merge?

>> Ultimately I think the KubeVirt community will need an event virtual
>> or otherwise akin to OpenStack's Project Team Gatherings [1] or
>> Kubernetes Contributor Summit [2] in the near future to help teams
>> work through proposals etc early in the cycle. Yes the summit is
>> useful but a few days of presentations is very different to the
>> aforementioned meetings. Anyway that's for another suggestion thread.
>>
>> 3. Updating the template with suggestions from KEPs
>>
>> Comparing our current template with the k8s KEP template we appear to
>> be missing some useful sections like `troubleshooting` etc that might
>> be worth adding. Additionally a release checklist would be good to add
>> to our template but as these proposals are optional that might be too
>> heavy weight for now.
>
> 10x

As above I think this needs to happen once the community decides if it
wants to go ahead with renaming and moving things.

Cheers,

Lee

Luboslav Pivarc

unread,
Jun 15, 2023, 6:29:51 AM6/15/23
to Lee Yarwood, kubevirt-dev
Hey Lee,

On Thu, Jun 8, 2023 at 5:28 PM Lee Yarwood <lyar...@redhat.com> wrote:
Hello all,

I wanted to raise a few changes I think would help improve the design
proposal process for new and old contributors in KubeVirt. I'll raise
this in the next community meeting but feedback is welcome here until
then.

1. s/design-proposals/enhancements/g

I personally found it odd that these proposals lived in the community
repo, IMHO moving them to a stand alone enhancements repo and
obviously renaming the overall process would be useful for new
contributors coming from the wider k8s eco-system.

2. Adding enhancement review time and a soft deadline to the start of
a release cycle

With our move to a longer release cycle I would like to see more
emphasis given to these enhancement proposals earlier in the cycle,
both by contributors and reviewers. Adding some kind of
proposal/review window and/or soft deadline could help focus everyone
on getting agreement earlier in the cycle.

Ultimately I think the KubeVirt community will need an event virtual
or otherwise akin to OpenStack's Project Team Gatherings [1] or
Kubernetes Contributor Summit [2] in the near future to help teams
work through proposals etc early in the cycle. Yes the summit is
useful but a few days of presentations is very different to the
aforementioned meetings. Anyway that's for another suggestion thread.

To keep things loose we could think about the following:
1. Encourage but do not insist to tide proposals for part of the release.
2. Emphasize that posting proposals early are more likely to be reviewed and finalized before the next release cycle.
3. Call out proposals on community calls repetitively until they do have the needed attention.

More or less this is what we are doing but having it written down can help to communicate it to newcomers and ensure consistency in our process.

-Lubo
 

3. Updating the template with suggestions from KEPs

Comparing our current template with the k8s KEP template we appear to
be missing some useful sections like `troubleshooting` etc that might
be worth adding. Additionally a release checklist would be good to add
to our template but as these proposals are optional that might be too
heavy weight for now.

Regards,

Lee

[1] https://openinfra.dev/ptg/
[2] https://www.kubernetes.dev/events/2023/kcseu/

Reply all
Reply to author
Forward
0 new messages