e2e Feature Gate testing

[antonio.o...@gmail.com]

Hi,

for context https://github.com/kubernetes/kubernetes/pull/99777#discussion_r622296785

Is there a canonical way or some path we want to follow for e2e testing and feature gates?

I see that we have tags on the test description for filtering with ginkgo.focus and ginkgo. skip [Feature:foo].

However, Ricardo just found that we also have a map that can be populated from the e2e binary, that I honestly didn't know about it:

// featureGates is a map of feature names to bools that enable or disable alpha/experimental features.

FeatureGates map[string]bool

I think It will be good to pick one  method for implementing e2e tests under feature gates to have some consistency.

Regards,

Antonio Ojea

[spi...@google.com]

I replied on the PR in question https://github.com/kubernetes/kubernetes/pull/99777/files#r638138521

It's just my take as a chair, and I'm only one person.  I'm certainly open to other opinions or interpretations.  If we blow scope on that PR we can move to a discussion over in https://github.com/kubernetes/sig-testing/discussions

- aaron

[Antonio Ojea]

On Mon, 24 May 2021 at 19:28, 'spi...@google.com' via kubernetes-sig-testing <kubernetes-...@googlegroups.com> wrote:

I replied on the PR in question https://github.com/kubernetes/kubernetes/pull/99777/files#r638138521

It's just my take as a chair, and I'm only one person.  I'm certainly open to other opinions or interpretations.  If we blow scope on that PR we can move to a discussion over in https://github.com/kubernetes/sig-testing/discussions

I agree with you and your comment , so we are 2 now :)

 

- aaron

On Thursday, April 29, 2021 at 3:23:22 AM UTC-4 antonio.o...@gmail.com wrote:

Hi,

for context https://github.com/kubernetes/kubernetes/pull/99777#discussion_r622296785

Is there a canonical way or some path we want to follow for e2e testing and feature gates?

I see that we have tags on the test description for filtering with ginkgo.focus and ginkgo. skip [Feature:foo].

However, Ricardo just found that we also have a map that can be populated from the e2e binary, that I honestly didn't know about it:

// featureGates is a map of feature names to bools that enable or disable alpha/experimental features.

FeatureGates map[string]bool

I think It will be good to pick one  method for implementing e2e tests under feature gates to have some consistency.

Regards,

Antonio Ojea

--
You received this message because you are subscribed to the Google Groups "kubernetes-sig-testing" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-te...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-testing/299e0d8b-28b2-4c9b-bbe4-b6a1c14161dbn%40googlegroups.com.