Exception: Kubernetes CSI topology support

[Cheng Xing]

Hi all,

I'd like to file an exception for the CSI topology support feature. The core PR was close to being merged but there was one comment I couldn't address in time.

Feature name: Kubernetes CSI topology support

Feature status (alpha/beta/stable): alpha
SIG: Storage

K/Features repo issue #: https://github.com/kubernetes/features/issues/557
PR #’s: https://github.com/kubernetes/kubernetes/pull/67684
Additional time needed (in days): 5
Reason this feature is critical for this milestone: Many CSI drivers are inoperable without topology support, and we would like to have stable core CSI support as soon as possible to allow storage vendors to deploy production-ready drivers in Kubernetes. The goal is to have CSI GA by Q4 2018.
Risks from adding code late: (to k8s stability, testing, etc.) This feature will be hidden behind feature gates, so it should be low risk.
Risks from cutting feature: (partial implementation, critical customer usecase, etc.) Although most CSI components are out-of-tree, the in-tree component delivers the essential node-level information that out-of-tree components rely upon. CSI adoption will be delayed among storage vendors, making it more difficult for Kubernetes to support a wider range of storage systems.

Thanks,

Cheng

[Timothy Pepper]

This is already a tracked feature and is expected in the release, so no exception required.

 

One point of clarification though:  I’ve seen this noted as alpha and beta in different places.  It is entering for the first time now?  But intended to be beta, and go to stable/GA along with CSI in the next cycle?

 

And one worry:  This is size/XXL.  We have a lot of instability in CI Signal right now.  We will really really need SIG Storage keeping an eye on testgrid results in general and around this set of CSI code as it merged.

 

Process background if there’s any confusion still:  In prior code freezes at this point you would need the normal set of PR labels, PLUS set “/milestone v1.12”, PLUS set the “status/approved-for-milestone”.  Those latter two are set by the same folks (https://github.com/orgs/kubernetes/teams/kubernetes-milestone-maintainers/members) and thus are redundant.  So we dropped the status one.  Bradley Childs and Saad Ali are the rep’s from SIG Storage, so they can set or unset this for the PR when it is ready.  Otherwise right now all that’s missing is the notation of actual readiness…/lgtm and /approve.

 

-- 

Tim Pepper

Orchestration & Containers Lead

VMware Open Source Technology Center

[Cheng Xing]

Thanks Tim!

The confusion of feature status might have come from the fact that the Topology feature is spread across several components. This is the first quarter we are introducing the concept of CSI Topology into Kubernetes, and both the kubelet (in-tree) and the external-provisioner (out-of-tree) need to be updated for the entire machinery to work. The original intention for the in-tree kubelet logic was to piggyback on the KubeletPluginsWatcher feature that it depends on, and KubeletPluginsWatcher is going to beta this quarter. But after further discussion we are planning to instead put this logic under a separate alpha gate, since it's not yet ready for beta.

Most of the PR delta comes from renaming one of the files (labelmanager.go -> nodeinfomanager.go) and a massive unit test file (nodeinfomanager_test.go). The logic will also be hidden behind an alpha feature gate so it should only affect test suites with alpha clusters. That said, I'll definitely keep an eye on our testgrid once this is merged.

Hope that helps.

Cheng

--
You received this message because you are subscribed to the Google Groups "kubernetes-sig-storage-wg-csi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to kubernetes-sig-stora...@googlegroups.com.
To post to this group, send email to kubernetes-sig...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/kubernetes-sig-storage-wg-csi/B306E974-5F33-42A6-BE56-8837F6C80512%40vmware.com.
For more options, visit https://groups.google.com/d/optout.