Re: [kubernetes/kubernetes] Stop sorting downward api file lines (#65992)

1 view
Skip to first unread message

Jordan Liggitt

unread,
Jul 9, 2018, 3:46:44 PM7/9/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

@kubernetes/sig-storage-pr-reviews


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

k8s-ci-robot

unread,
Jul 9, 2018, 4:47:48 PM7/9/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-100-performance 3f09fec link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Jordan Liggitt

unread,
Jul 9, 2018, 8:04:02 PM7/9/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

/retest

Tim Xu

unread,
Jul 9, 2018, 11:31:21 PM7/9/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

@xiaoxubeii approved this pull request.

Jan Šafránek

unread,
Jul 10, 2018, 4:05:24 AM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

/lgtm

k8s-ci-robot

unread,
Jul 10, 2018, 4:07:57 AM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane, liggitt
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: smarterclayton

If they are not already assigned, you can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Jordan Liggitt

unread,
Jul 10, 2018, 5:36:01 PM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

/assign @thockin
for pkg/fieldpath change

Tim Hockin

unread,
Jul 10, 2018, 6:35:01 PM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

/lgtm
/approve

k8s-ci-robot

unread,
Jul 10, 2018, 6:35:24 PM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, liggitt, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Kubernetes Submit Queue

unread,
Jul 10, 2018, 7:41:06 PM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

/test all [submit-queue is verifying that this PR is safe to merge]

Kubernetes Submit Queue

unread,
Jul 10, 2018, 8:02:55 PM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

Automatic merge from submit-queue (batch tested with PRs 66038, 65992, 66008). If you want to cherry-pick this change to another branch, please follow the instructions here.

Kubernetes Submit Queue

unread,
Jul 10, 2018, 8:03:19 PM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

Merged #65992.

k8s-ci-robot

unread,
Jul 10, 2018, 8:09:53 PM7/10/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

@liggitt: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kops-aws 3f09fec link /test pull-kubernetes-e2e-kops-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ryan

unread,
Jul 11, 2018, 12:32:58 PM7/11/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

Thanks @liggitt

Can we backport this fix to 1.11? @liggitt or @thockin ?
Since 1.12 is a ways out

Jordan Liggitt

unread,
Jul 11, 2018, 1:08:07 PM7/11/18
to kubernetes/kubernetes, k8s-mirror-storage-pr-reviews, Team mention

Can we backport this fix to 1.11?

I think that's reasonable. Opened #66077

Reply all
Reply to author
Forward
0 new messages